diff mbox

batman-adv: a multiline comment should precede the variable it is describing

Message ID 1305730043-3666-1-git-send-email-ordex@autistici.org (mailing list archive)
State Accepted, archived
Commit 8f8ca0591a4ae207a7d34ae1875a58c768007cb0
Headers

Commit Message

Antonio Quartulli May 18, 2011, 2:47 p.m. UTC 
  This comment has been wrongly put after the variable it refers to and was also bad indented

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---

 types.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Comments

Sven Eckelmann May 19, 2011, 7:40 p.m. UTC | #1 
Antonio Quartulli wrote:
> This comment has been wrongly put after the variable it refers to and was
> also bad indented
> 
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
> 
>  types.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/types.h b/types.h
> index fab70e8..65b3222 100644
> --- a/types.h
> +++ b/types.h
> @@ -246,10 +246,10 @@ struct frag_packet_list_entry {
>  };
> 
>  struct vis_info {
> -	unsigned long       first_seen;
> -	struct list_head    recv_list;
> -			    /* list of server-neighbors we received a vis-packet
> -			     * from.  we should not reply to them. */
> +	unsigned long first_seen;
> +	/* list of server-neighbors we received a vis-packet
> +	 * from.  we should not reply to them. */
> +	struct list_head recv_list;
>  	struct list_head send_list;
>  	struct kref refcount;
>  	struct hlist_node hash_entry;

Acked-by: Sven Eckelmann <sven@narfation.org>
Marek Lindner May 22, 2011, 9:20 a.m. UTC | #2 
On Wednesday 18 May 2011 16:47:23 Antonio Quartulli wrote:
> This comment has been wrongly put after the variable it refers to and was
> also bad indented

Applied in revision 8f8ca05.

Thanks,
Marek
diff mbox

Patch

diff --git a/types.h b/types.h
index fab70e8..65b3222 100644
--- a/types.h
+++ b/types.h
@@ -246,10 +246,10 @@  struct frag_packet_list_entry {
 };
 
 struct vis_info {
-	unsigned long       first_seen;
-	struct list_head    recv_list;
-			    /* list of server-neighbors we received a vis-packet
-			     * from.  we should not reply to them. */
+	unsigned long first_seen;
+	/* list of server-neighbors we received a vis-packet
+	 * from.  we should not reply to them. */
+	struct list_head recv_list;
 	struct list_head send_list;
 	struct kref refcount;
 	struct hlist_node hash_entry;