[2/2] batman-adv: Fix signedness problem in parse_gw_bandwidth
Commit Message
strict_strtoul as used in parse_gw_bandwidth is defined for unsigned
long and strict_strtol should be used instead for long.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
gateway_common.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Comments
On Saturday 04 June 2011 12:40:38 Sven Eckelmann wrote:
> strict_strtoul as used in parse_gw_bandwidth is defined for unsigned
> long and strict_strtol should be used instead for long.
Don't we need a strict_strtol macro in compat.h next to the strict_strtoul
that we have now ?
Cheers,
Marek
Marek Lindner wrote:
> On Saturday 04 June 2011 12:40:38 Sven Eckelmann wrote:
> > strict_strtoul as used in parse_gw_bandwidth is defined for unsigned
> > long and strict_strtol should be used instead for long.
>
> Don't we need a strict_strtol macro in compat.h next to the strict_strtoul
> that we have now ?
Yes, forgot to add that change to the patch.
Kind regards,
Sven
@@ -97,7 +97,7 @@ static bool parse_gw_bandwidth(struct net_device *net_dev, char *buff,
*tmp_ptr = '\0';
}
- ret = strict_strtoul(buff, 10, &ldown);
+ ret = strict_strtol(buff, 10, &ldown);
if (ret) {
bat_err(net_dev,
"Download speed of gateway mode invalid: %s\n",
@@ -122,7 +122,7 @@ static bool parse_gw_bandwidth(struct net_device *net_dev, char *buff,
*tmp_ptr = '\0';
}
- ret = strict_strtoul(slash_ptr + 1, 10, &lup);
+ ret = strict_strtol(slash_ptr + 1, 10, &lup);
if (ret) {
bat_err(net_dev,
"Upload speed of gateway mode invalid: "