diff mbox

batman-adv: Omit unnecessary memset of netdev private data

Message ID 20170317110859.9273-1-tklauser@distanz.ch (mailing list archive)
State Accepted, archived
Commit 9210dca17a0acc2d01928893a61647153d578e33
Headers

Commit Message

Tobias Klauser March 17, 2017, 11:08 a.m. UTC 
  The memory for netdev_priv is allocated using kzalloc in alloc_netdev
(or alloc_netdev_mq respectively) so there is no need to set it to 0
again.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 net/batman-adv/soft-interface.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Sven Eckelmann March 17, 2017, 11:54 a.m. UTC | #1 
On Freitag, 17. März 2017 12:08:59 CET Tobias Klauser wrote:
> The memory for netdev_priv is allocated using kzalloc in alloc_netdev
> (or alloc_netdev_mq respectively) so there is no need to set it to 0
> again.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  net/batman-adv/soft-interface.c | 4 ----
>  1 file changed, 4 deletions(-)

Thanks, applied in 9210dca17a0acc2d01928893a61647153d578e33 [1].

Kind regards,
	Sven

[1] https://git.open-mesh.org/batman-adv.git/commit/9210dca17a0acc2d01928893a61647153d578e33
diff mbox

Patch

diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index 5d099b2e6cfc..8226495c6664 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -972,8 +972,6 @@  static void batadv_softif_free(struct net_device *dev)
  */
 static void batadv_softif_init_early(struct net_device *dev)
 {
-	struct batadv_priv *priv = netdev_priv(dev);
-
 	ether_setup(dev);
 
 	dev->netdev_ops = &batadv_netdev_ops;
@@ -990,8 +988,6 @@  static void batadv_softif_init_early(struct net_device *dev)
 	eth_hw_addr_random(dev);
 
 	dev->ethtool_ops = &batadv_ethtool_ops;
-
-	memset(priv, 0, sizeof(*priv));
 }
 
 struct net_device *batadv_softif_create(struct net *net, const char *name)