mbox series

[v3,0/4] batctl: netlink support for DAT and MCAST

Message ID 20180313104358.19895-1-linus.luessing@c0d3.blue (mailing list archive)
Headers
Series batctl: netlink support for DAT and MCAST |

Message

Linus Lüssing March 13, 2018, 10:43 a.m. UTC 
  This patchset adds netlink support for dumping DAT cache and multicast
flags tables.


Changes in v3:
==============
- renamed netlink attributes:
  - BATADV_ATTR_DC_ADDRESS   -> BATADV_ATTR_DAT_CACHE_IP4ADDRESS
  - BATADV_ATTR_DC_HWADDRESS -> BATADV_ATTR_DAT_CACHE_HWADDRESS
  - BATADV_ATTR_DC_VID       -> BATADV_ATTR_DAT_CACHE_VID

Changes in v2:
==============

- Removed htonl() conversion for BATADV_ATTR_DC_ADDRESS as batman-adv
  now provides it in network byte order (via nla_put_in_addr() )
- Increased BATADV_ATTR_MCAST_FLAGS and BATADV_ATTR_MCAST_FLAGS_PRIV
  size from 8 to 32 bits to enhance extensibility
- Changed mcast_flags error value from -EINVAL to -ENOTSUPP to allow
  a fallback to and retry via debugfs, for compatibility with older
  batman-adv versions

Comments

Sven Eckelmann March 14, 2018, 10:25 a.m. UTC | #1 
On Dienstag, 13. März 2018 11:43:54 CET Linus Lüssing wrote:
> This patchset adds netlink support for dumping DAT cache and multicast
> flags tables.
> 
> 
> Changes in v3:
> ==============
> - renamed netlink attributes:
>   - BATADV_ATTR_DC_ADDRESS   -> BATADV_ATTR_DAT_CACHE_IP4ADDRESS
>   - BATADV_ATTR_DC_HWADDRESS -> BATADV_ATTR_DAT_CACHE_HWADDRESS
>   - BATADV_ATTR_DC_VID       -> BATADV_ATTR_DAT_CACHE_VID
> 
> Changes in v2:
> ==============
> 
> - Removed htonl() conversion for BATADV_ATTR_DC_ADDRESS as batman-adv
>   now provides it in network byte order (via nla_put_in_addr() )
> - Increased BATADV_ATTR_MCAST_FLAGS and BATADV_ATTR_MCAST_FLAGS_PRIV
>   size from 8 to 32 bits to enhance extensibility
> - Changed mcast_flags error value from -EINVAL to -ENOTSUPP to allow
>   a fallback to and retry via debugfs, for compatibility with older
>   batman-adv versions
> 

Applied in bfff37a..b560610 [1]

Thanks,
	Sven

[1] https://git.open-mesh.org/batctl.git/commit/c353d3a0da6068fd759ebf96727189fcc3c3dbae
    https://git.open-mesh.org/batctl.git/commit/33260655b3b029b05f76fbc71d1bcdd4aa5c655b
    https://git.open-mesh.org/batctl.git/commit/c1bb431577f1b2a4250a780f9c29355eb3694ff9
    https://git.open-mesh.org/batctl.git/commit/b56061058113913c9e16b388761b873ab216e1d4