Message ID | 20181207203209.22633-1-sven@narfation.org (mailing list archive) |
---|---|
Headers |
Return-Path: <b.a.t.m.a.n-bounces@lists.open-mesh.org> X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id 4877F80D13; Fri, 7 Dec 2018 21:32:20 +0100 (CET) Authentication-Results: open-mesh.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=narfation.org header.i=@narfation.org header.b="jmAgh/LF"; dkim-atps=neutral Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=79.140.41.39; helo=v3-1039.vlinux.de; envelope-from=sven@narfation.org; receiver=<UNKNOWN> Received: from v3-1039.vlinux.de (narfation.org [79.140.41.39]) by open-mesh.org (Postfix) with ESMTPS id 37F44801E0 for <b.a.t.m.a.n@lists.open-mesh.org>; Fri, 7 Dec 2018 21:32:17 +0100 (CET) Received: from sven-desktop.home.narfation.org (p200300C5970891FD0000000000008096.dip0.t-ipconnect.de [IPv6:2003:c5:9708:91fd::8096]) by v3-1039.vlinux.de (Postfix) with ESMTPSA id 792591100D6; Fri, 7 Dec 2018 21:32:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=narfation.org; s=20121; t=1544214737; bh=NbSntXNxQoXkhsvOGtnmgi4R41IY75kJEv6RXKb5Abc=; h=From:To:Cc:Subject:Date:From; b=jmAgh/LFTLWrj6OOcoe/NUfEiWDSD8uHTLbiqN+9T/bFOMgwLKGtmkEbu2H9DMuXw /gb9ZGeBWx/cMsvY6uAm2KDJ2XD++eccU8uLnM1c6eNtlnFGxDkb8UR3QXHPU6diMd GSAZzO4AgVcvMSDWOORqmLwuF9SXb95gh4Cl1+dY= From: Sven Eckelmann <sven@narfation.org> To: b.a.t.m.a.n@lists.open-mesh.org Date: Fri, 7 Dec 2018 21:31:49 +0100 Message-Id: <20181207203209.22633-1-sven@narfation.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [B.A.T.M.A.N.] [RFC v4 00/20] batctl: netlink restructuring, part 3 X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n.lists.open-mesh.org> List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe> List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/> List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org> List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help> List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org> Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org> |
Series |
batctl: netlink restructuring, part 3
|
|
Message
Sven Eckelmann
Dec. 7, 2018, 8:31 p.m. UTC
As mentioned earlier, the netlink config restructuring in batctl will be splitted in multiple steps. The first step was already merged and the RFC changes for the netlink interface in batman-adv were just posted. The batman-adv weren't directly rejected by Jiro and thus I've started to convert all settings to netlink while still allowing sysfs as fallback. v4: * last patch (which adds the netlink implementation of the settings commands) was splitted in 16 separate patches * Cc the (most likely) responsible developers for each setting to more directly ask them for feedback v3: * fix kernel-doc in batman_adv.h * add three patches to use the netlink interface with the already existing setting commands v2: * drop of generic config command * reimplementation of the event command Kind regards, Sven Sven Eckelmann (20): batctl: Add support for config mcast group in event monitor batctl: Don't allocate new buffer for vlan parent device batctl: Automatically translate vlan to mesh_iface batctl: Add settings_data hooks for netlink integration batctl: Parse the arguments for gw_mode batctl: Add netlink simple query helper batctl: Support generic netlink for gw_mode command batctl: Support generic netlink for loglevel command batctl: Support generic netlink for isolation_mark command batctl: Support generic netlink for orig_interval command batctl: Add helper to read/write boolean configuration values batctl: Support generic netlink for aggregation command batctl: Support generic netlink for ap_isolation command batctl: Support generic netlink for bonding command batctl: Support generic netlink for bridge_loop_avoidance command batctl: Support generic netlink for distributed_arp_table command batctl: Support generic netlink for fragmentation command batctl: Support generic netlink for multicast_mode command batctl: Support generic netlink for network_coding command batctl: Drop settings_date param lists aggregation.c | 45 ++++- ap_isolation.c | 67 ++++++- batman_adv.h | 188 +++++++++++++++++- bonding.c | 45 ++++- bridge_loop_avoidance.c | 46 ++++- distributed_arp_table.c | 46 ++++- event.c | 234 ++++++++++++++++++++++ fragmentation.c | 45 ++++- functions.c | 160 +++++++++++++--- functions.h | 23 ++- gateways.c | 10 +- gw_mode.c | 416 +++++++++++++++++++++++++++++++--------- isolation_mark.c | 123 +++++++++++- loglevel.c | 138 ++++++++++--- main.c | 10 +- main.h | 6 +- mcast_flags.c | 10 +- multicast_mode.c | 45 ++++- netlink.c | 108 ++++++++++- netlink.h | 2 + network_coding.c | 45 ++++- orig_interval.c | 84 +++++++- originators.c | 10 +- routing_algo.c | 1 - sys.c | 219 ++++++++++++++++----- sys.h | 25 ++- 26 files changed, 1895 insertions(+), 256 deletions(-)
Comments
On Fri, Dec 07, 2018 at 09:31:49PM +0100, Sven Eckelmann wrote: > As mentioned earlier, the netlink config restructuring in batctl will be > splitted in multiple steps. The first step was already merged and the > RFC changes for the netlink interface in batman-adv were just posted. > > The batman-adv weren't directly rejected by Jiro and thus I've started > to convert all settings to netlink while still allowing sysfs as fallback. > Is "batctl if" supposed to use netlink to get the interface status yet? Currently, with the items in *_attr[] in sysfs.c in batman-adv commented out, I get these errors: --- root@Linus-Debian:~# batctl if ens3: <error reading status> ens5: <error reading status> ---
On Monday, 7 January 2019 19.57.13 CET Linus Lüssing wrote: [...] > Is "batctl if" supposed to use netlink to get the interface status > yet? > > Currently, with the items in *_attr[] in sysfs.c in batman-adv > commented out, I get these errors: > > --- > root@Linus-Debian:~# batctl if > ens3: <error reading status> > ens5: <error reading status> > --- Not yet, but I think we should switch to it in the near future. Kind regards, Sven