diff mbox

Send TUNNEL_IP_REQUEST as response of TUNNEL_IP_REQUEST

Message ID 20080924215939.GA9277@sven-desktop.lazhur.ath.cx (mailing list archive)
State Accepted, archived
Headers

Commit Message

Sven Eckelmann Sept. 24, 2008, 9:59 p.m. UTC 
  Userspace gateway sends TUNNEL_IP_REQUEST when he receives TUNNEL_IP_REQUEST
and will not start to send new IP as TUNNEL_DATA
---
 batman/linux/modules/gateway.c   |    1 -
 batman/linux/modules/gateway24.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

Comments

Stephan Enderlein (Freifunk Dresden) Sept. 25, 2008, 9:12 a.m. UTC | #1 
Hello Sven,

It seems that you are always replying to emails of a different thread.
The information you send do not belong to my questions.
I also have seen that you replay to other threads that is not related
to the threads.
Please create a new thread instead for you PATCH messages as it would
keep the thread in correct order.

Bye
 Stephan
Sven Eckelmann Sept. 25, 2008, 9:33 a.m. UTC | #2 
On Thursday 25 September 2008 11:12:11 Stephan Enderlein (Freifunk Dresden) 
wrote:
> It seems that you are always replying to emails of a different thread.
> The information you send do not belong to my questions.
> I also have seen that you replay to other threads that is not related
> to the threads.
> Please create a new thread instead for you PATCH messages as it would
> keep the thread in correct order.
Sry, I haven't replied to any threads with my [PATCH] mails. Please check your 
mua and the mail headers of my [PATCH] mails. You will notice that there are 
no In-Reply-To or References in them - just the usual stuff mutt creates for 
"new" mails and the stuff mailman adds.

Best regards
	Sven Eckelmann
Stephan Enderlein (Freifunk Dresden) Sept. 26, 2008, 11:19 a.m. UTC | #3 
Hi,

> Sry, I haven't replied to any threads with my [PATCH] mails. Please check
> your
> mua and the mail headers of my [PATCH] mails. You will notice that there
> are
> no In-Reply-To or References in them - just the usual stuff mutt creates
> for
> "new" mails and the stuff mailman adds.

When I display the complete email header of you emails I have the following
line:
"In-Reply-To: <6fd627b9bdd448cd88026446baddb8a5.squirrel@wm.ddmesh.de>"
For some reason you are creating emails with that header entry instead
without it.

Please also look at the archive at
https://list.open-mesh.net/pipermail/b.a.t.m.a.n/2008-September/thread.html.
You will see that only your mails are always appended to other threads and
are not starting as a new thread. All answers are currently under
"[B.A.T.M.A.N.] batman-exp hang on 95% CPU load" which definitively do not
belong to the subject.
Please check your environment.

Bye
 Stephan


---------------------------------------
Dipl.Informatiker(FH) Stephan Enderlein
Freifunk Dresden
Sven Eckelmann Sept. 26, 2008, 11:39 a.m. UTC | #4 
On Friday 26 September 2008 13:19:19 Stephan Enderlein (Freifunk Dresden) 
wrote:
> [...]
> When I display the complete email header of you emails I have the following
> line:
> "In-Reply-To: <6fd627b9bdd448cd88026446baddb8a5.squirrel@wm.ddmesh.de>"
> For some reason you are creating emails with that header entry instead
> without it.
Can you please say which mail you mean? I checked different [PATCH] mails from 
me (send by mailman back to me) and cannot find it. The only ones which have 
them are the the real answers to your mails - which off course have references 
to them.

grep -rli "6fd627b9bdd448cd88026446baddb8a5.squirrel@wm.ddmesh.de" *|xargs 
grep Subject                                                                                   
1222335445.3922.Wd6Iu:2,S:Subject: Re: [B.A.T.M.A.N.] [PATCH] Send 
TUNNEL_IP_REQUEST as response of

1222334362.3922.FhPMA:2,RS:Subject: Re: [B.A.T.M.A.N.] [PATCH] Send 
TUNNEL_IP_REQUEST as response of

1222428286.3965.lxuDX:Subject: Re: [B.A.T.M.A.N.] [PATCH] Send 
TUNNEL_IP_REQUEST as response o


> Please also look at the archive at
> https://list.open-mesh.net/pipermail/b.a.t.m.a.n/2008-September/thread.html
>. You will see that only your mails are always appended to other threads and
> are not starting as a new thread. All answers are currently under
> "[B.A.T.M.A.N.] batman-exp hang on 95% CPU load" which definitively do not
> belong to the subject.
> Please check your environment.
I have asked dotslash to check it on his machine and he doesn't see my mails 
in your threads in mutt. It's the same with kmail and probably with many other 
mail clients. I cannot find the problem on my site so I would say that it is a 
problem of mailman's archive output. I have contacted the postmaster of open-
mesh, but got no answer until now.

Best regards
	Sven Eckelmann
Sven Eckelmann Sept. 26, 2008, 12:19 p.m. UTC | #5 
On Friday 26 September 2008 13:39:30 Sven Eckelmann wrote:
> On Friday 26 September 2008 13:19:19 Stephan Enderlein (Freifunk Dresden)
> > [...]
> > When I display the complete email header of you emails I have the
> > following line:
> > "In-Reply-To: <6fd627b9bdd448cd88026446baddb8a5.squirrel@wm.ddmesh.de>"
> > For some reason you are creating emails with that header entry instead
> > without it.
>
> Can you please say which mail you mean? I checked different [PATCH] mails
> from me (send by mailman back to me) and cannot find it. The only ones
> which have them are the the real answers to your mails - which off course
> have references to them.
>
> grep -rli "6fd627b9bdd448cd88026446baddb8a5.squirrel@wm.ddmesh.de" *|xargs
> grep Subject
> 1222335445.3922.Wd6Iu:2,S:Subject: Re: [B.A.T.M.A.N.] [PATCH] Send
> TUNNEL_IP_REQUEST as response of
>
> 1222334362.3922.FhPMA:2,RS:Subject: Re: [B.A.T.M.A.N.] [PATCH] Send
> TUNNEL_IP_REQUEST as response of
>
> 1222428286.3965.lxuDX:Subject: Re: [B.A.T.M.A.N.] [PATCH] Send
> TUNNEL_IP_REQUEST as response o

To have the same data please download
  https://list.open-mesh.net/pipermail/b.a.t.m.a.n/2008-September.txt.gz
and search for
  Message-ID: <20080924215939.GA9277@sven-desktop.lazhur.ath.cx>
This is the first mail which is displayed as answer to your mail inside the 
threaded archive output. Do you see anything which justifies that this mail is 
attached to your mail in the thread?

Now search for
  Message-ID: <6fd627b9bdd448cd88026446baddb8a5.squirrel@wm.ddmesh.de>
This is the mail you wrote that you think that I "answered" to your mail. Do 
you find the In-Reply-To and References? I do - and this should be the only 
real reason that your mail is a answer to my mail for a mail reader (and for 
the archive output of mailman of course).

Best regards,
	Sven Eckelmann
Stephan Enderlein (Freifunk Dresden) Sept. 26, 2008, 12:56 p.m. UTC | #6 
Hi,

>   https://list.open-mesh.net/pipermail/b.a.t.m.a.n/2008-September.txt.gz
If I look at this file I agree with you that there is no In-Replay-To.
But the email header is normaly much longer. So we can see this if you
create a new message for the list (not a reply).
The mailing list modifies the emails and removes a lot of header entries.

Perhaps the mailing list has a problem with multi-part email. Have you
tried to send new emails without attachments/pgp?
If it is working than the mailing ist has a problem with that and
attachments should be avoided.

see:
----------------
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url :
http://list.open-mesh.net/pipermail/b.a.t.m.a.n/attachments/20080912/69d789a8/attachment.pgp
From sven.eckelmann at gmx.de  Fri Sep 12 16:59:45 2008
----------------

/Stephan

---------------------------------------
Dipl.Informatiker(FH) Stephan Enderlein
Freifunk Dresden
Sven Eckelmann Sept. 26, 2008, 1:06 p.m. UTC | #7 
On Friday 26 September 2008 14:56:17 Stephan Enderlein (Freifunk Dresden) 
wrote:
> >   https://list.open-mesh.net/pipermail/b.a.t.m.a.n/2008-September.txt.gz
>
> If I look at this file I agree with you that there is no In-Replay-To.
> But the email header is normaly much longer. So we can see this if you
> create a new message for the list (not a reply).
> The mailing list modifies the emails and removes a lot of header entries.
I know, but this should be the important fields for mailman hyper-archiver.

> Perhaps the mailing list has a problem with multi-part email. Have you
> tried to send new emails without attachments/pgp?
> If it is working than the mailing ist has a problem with that and
> attachments should be avoided.
I never send these patches as multipart mails with pgp stuff - just simple 
text/plain mails


Best regards,
	Sven
Marek Lindner Sept. 26, 2008, 3:49 p.m. UTC | #8 
On Friday, 26. September 2008 21:06:16 Sven Eckelmann wrote:
> > Perhaps the mailing list has a problem with multi-part email. Have you
> > tried to send new emails without attachments/pgp?
> > If it is working than the mailing ist has a problem with that and
> > attachments should be avoided.
>
> I never send these patches as multipart mails with pgp stuff - just simple
> text/plain mails

True, its always "Content-Type: text/plain;".

I have no problem with your mails - they are displayed as expected.  :-)


Greetings,
Marek
diff mbox

Patch

diff --git a/batman/linux/modules/gateway.c b/batman/linux/modules/gateway.c
index 154497e..9411575 100644
--- a/batman/linux/modules/gateway.c
+++ b/batman/linux/modules/gateway.c
@@ -405,7 +405,6 @@  static int packet_recv_thread(void *data)
 
 				if(client_data != NULL) {
 
-					buffer[0] = TUNNEL_DATA;
 					memcpy( &buffer[1], &client_data->vip_addr, sizeof( client_data->vip_addr ) );
 
 					iov.iov_base = buffer;
diff --git a/batman/linux/modules/gateway24.c b/batman/linux/modules/gateway24.c
index 585fe85..9b60fe4 100644
--- a/batman/linux/modules/gateway24.c
+++ b/batman/linux/modules/gateway24.c
@@ -385,7 +385,6 @@  static int packet_recv_thread(void *data)
 
 				if(client_data != NULL) {
 
-					buffer[0] = TUNNEL_DATA;
 					memcpy( &buffer[1], &client_data->vip_addr, sizeof( client_data->vip_addr ) );
 
 					iov.iov_base = buffer;