[v4,1/4] batman-adv: Keep hard interface neighbor list sorted
Commit Message
The upcoming neighborhood hashing will compute a hash over the MAC
address of all neighbors on an interface, from the smallest to the
largest one.
This patch keeps the hard interface neighbor list in order to ease
the hash computation later.
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
Changes in v4:
* none
Changes in v3:
* add missing compat code for hlist_add_behind_rcu()
(thanks Sven!)
* add linux/string.h in this instead of the next patch,
memcmp in originator.h was introduced here already
Changes in v2:
* Moved sorted storing of hardif neighbors to this separate patch
* fix rcu bug: use hlist_add_{head,behind}_rcu() instead of their
non-rcu variants (and rebase on top of Sven's maint patch for the
original hlist_add_head() )
(thanks Sven!)
---
compat-include/linux/rculist.h | 8 ++++++-
net/batman-adv/originator.c | 49 ++++++++++++++++++++++++++++++++++++++++--
2 files changed, 54 insertions(+), 3 deletions(-)
@@ -34,6 +34,12 @@
pos = hlist_entry_safe(rcu_dereference_raw(hlist_next_rcu(\
&(pos)->member)), typeof(*(pos)), member))
-#endif
+#endif /* < KERNEL_VERSION(3, 9, 0) */
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0)
+
+#define hlist_add_behind_rcu(n, prev) hlist_add_after_rcu(prev, n)
+
+#endif /* < KERNEL_VERSION(3, 17, 0) */
#endif /* _NET_BATMAN_ADV_COMPAT_LINUX_RCULIST_H_ */
@@ -34,6 +34,7 @@
#include <linux/skbuff.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
+#include <linux/string.h>
#include <linux/workqueue.h>
#include <net/sock.h>
#include <uapi/linux/batman_adv.h>
@@ -509,6 +510,43 @@ batadv_neigh_node_get(const struct batadv_orig_node *orig_node,
}
/**
+ * batadv_hardif_neigh_get_pre - get the predecessor of a neighbor node
+ * @hard_iface: the interface this neighbour is connected to
+ * @neigh_addr: address of the neighbour to retrieve the predecessor for
+ *
+ * Tries to find the neighbor node which has an address closest to but
+ * smaller than the neigh_addr provided. In other words, tries to
+ * find a potential predecessor of a given MAC address.
+ *
+ * Return: The alphabetical predecessor of a neighbor node. Returns NULL
+ * if no such predecessor exists.
+ */
+static struct batadv_hardif_neigh_node *
+batadv_hardif_neigh_get_pre(struct batadv_hard_iface *hard_iface,
+ const u8 *neigh_addr)
+{
+ struct batadv_hardif_neigh_node *tmp_hardif_neigh, *hardif_neigh = NULL;
+
+ rcu_read_lock();
+ hlist_for_each_entry_rcu(tmp_hardif_neigh, &hard_iface->neigh_list,
+ list) {
+ if (memcmp(tmp_hardif_neigh->addr, neigh_addr, ETH_ALEN) >= 0)
+ break;
+
+ if (!kref_get_unless_zero(&tmp_hardif_neigh->refcount))
+ continue;
+
+ if (hardif_neigh)
+ batadv_hardif_neigh_put(hardif_neigh);
+
+ hardif_neigh = tmp_hardif_neigh;
+ }
+ rcu_read_unlock();
+
+ return hardif_neigh;
+}
+
+/**
* batadv_hardif_neigh_create - create a hardif neighbour node
* @hard_iface: the interface this neighbour is connected to
* @neigh_addr: the interface address of the neighbour to retrieve
@@ -522,7 +560,7 @@ batadv_hardif_neigh_create(struct batadv_hard_iface *hard_iface,
struct batadv_orig_node *orig_node)
{
struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);
- struct batadv_hardif_neigh_node *hardif_neigh;
+ struct batadv_hardif_neigh_node *hardif_neigh, *pre_neigh;
spin_lock_bh(&hard_iface->neigh_list_lock);
@@ -547,7 +585,14 @@ batadv_hardif_neigh_create(struct batadv_hard_iface *hard_iface,
if (bat_priv->algo_ops->neigh.hardif_init)
bat_priv->algo_ops->neigh.hardif_init(hardif_neigh);
- hlist_add_head_rcu(&hardif_neigh->list, &hard_iface->neigh_list);
+ pre_neigh = batadv_hardif_neigh_get_pre(hard_iface, neigh_addr);
+ if (!pre_neigh) {
+ hlist_add_head_rcu(&hardif_neigh->list,
+ &hard_iface->neigh_list);
+ } else {
+ hlist_add_behind_rcu(&hardif_neigh->list, &pre_neigh->list);
+ batadv_hardif_neigh_put(pre_neigh);
+ }
out:
spin_unlock_bh(&hard_iface->neigh_list_lock);