RFC: batman-adv: Increase hashtable size for the global translation table
diff mbox

Message ID 20170302094409.20995-1-linus.luessing@c0d3.blue
State RFC
Delegated to: Simon Wunderlich
Headers show

Commit Message

Linus Lüssing March 2, 2017, 9:44 a.m. UTC
With the addition of multicast optimization features in batman-adv
not only unicast but also multicast addresses are now fed into the
translatation table. This approximately increases the number of
entries by a factor of roughly 2 to 3.

Also, the number of client devices in some known, public mesh networks
has grown to nearly 4000.

Therefore this patch inceases the global translation table size from
1024 to 16384 to reduce load in larger mesh networks.

Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>

---
ToDo (maybe): Gather some statistics on how much this might reduce load
in some particular networks.

This might be a hotfix for some larger Freifunk mesh networks which are
experiencing a significantly higher load level since they switched to
a recent batman-adv version. Validating whether the hashtable size might
be the reason is currently being investigated.

On the long run we should switch to the resizable hash table implementation
the kernel now provides since not that long ago.
---
 net/batman-adv/translation-table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch
diff mbox

diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index e75b493..e87825c 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -1462,7 +1462,7 @@  static int batadv_tt_global_init(struct batadv_priv *bat_priv)
 	if (bat_priv->tt.global_hash)
 		return 0;
 
-	bat_priv->tt.global_hash = batadv_hash_new(1024);
+	bat_priv->tt.global_hash = batadv_hash_new(16384);
 
 	if (!bat_priv->tt.global_hash)
 		return -ENOMEM;