mbox series

[v3,0/2] batman-adv: netlink support for DAT and MCAST

Message ID 20180313104113.19654-1-linus.luessing@c0d3.blue
Headers show
Series batman-adv: netlink support for DAT and MCAST | expand

Message

Linus Lüssing March 13, 2018, 10:41 a.m. UTC
This patchset adds netlink support for dumping DAT cache and multicast
flags tables.


Changes in v3:
==============
- renamed netlink attributes:
  - BATADV_ATTR_DC_ADDRESS   -> BATADV_ATTR_DAT_CACHE_IP4ADDRESS
  - BATADV_ATTR_DC_HWADDRESS -> BATADV_ATTR_DAT_CACHE_HWADDRESS
  - BATADV_ATTR_DC_VID       -> BATADV_ATTR_DAT_CACHE_VID

Changes in v2:
==============

- Added missing includes, "#include <linux/netlink.h>" and
  "#include <uapi/linux/batman_adv.h>", to distributed-arp-table.c
- Added missing forward declaration for "struct netlink_callback" to
  distributed-arp-table.h
- Changed nla_put_u32() to nla_put_in_addr() for BATADV_ATTR_DC_ADDRESS,
  removed the then obsolete ntohl() conversion
- Added missing include, "#include <linux/netlink.h>", to multicast.c
- Changed nla_put_u8() to nla_put_u32() for BATADV_ATTR_MCAST_FLAGS and
  BATADV_ATTR_MCAST_FLAGS_PRIV to enhance extensibility

Comments

Sven Eckelmann March 14, 2018, 10:24 a.m. UTC | #1
On Dienstag, 13. März 2018 11:41:11 CET Linus Lüssing wrote:
> This patchset adds netlink support for dumping DAT cache and multicast
> flags tables.
> 
> 
> Changes in v3:
> ==============
> - renamed netlink attributes:
>   - BATADV_ATTR_DC_ADDRESS   -> BATADV_ATTR_DAT_CACHE_IP4ADDRESS
>   - BATADV_ATTR_DC_HWADDRESS -> BATADV_ATTR_DAT_CACHE_HWADDRESS
>   - BATADV_ATTR_DC_VID       -> BATADV_ATTR_DAT_CACHE_VID
> 
> Changes in v2:
> ==============
> 
> - Added missing includes, "#include <linux/netlink.h>" and
>   "#include <uapi/linux/batman_adv.h>", to distributed-arp-table.c
> - Added missing forward declaration for "struct netlink_callback" to
>   distributed-arp-table.h
> - Changed nla_put_u32() to nla_put_in_addr() for BATADV_ATTR_DC_ADDRESS,
>   removed the then obsolete ntohl() conversion
> - Added missing include, "#include <linux/netlink.h>", to multicast.c
> - Changed nla_put_u8() to nla_put_u32() for BATADV_ATTR_MCAST_FLAGS and
>   BATADV_ATTR_MCAST_FLAGS_PRIV to enhance extensibility

Applied in 0509fc0c..53c58c1e [1]

Thanks,
	Sven

[1] https://git.open-mesh.org/batman-adv.git/commit/9ae766e912b1bace4e7f3ce9960ee8a29ce61dce
    https://git.open-mesh.org/batman-adv.git/commit/9ae766e912b1bace4e7f3ce9960ee8a29ce61dce