mbox series

[RFC,v4,00/20] batctl: netlink restructuring, part 3

Message ID 20181207203209.22633-1-sven@narfation.org
Headers show
Series batctl: netlink restructuring, part 3 | expand

Message

Sven Eckelmann Dec. 7, 2018, 8:31 p.m. UTC
As mentioned earlier, the netlink config restructuring in batctl will be
splitted in multiple steps. The first step was already merged and the
RFC changes for the netlink interface in batman-adv were just posted.

The batman-adv weren't directly rejected by Jiro and thus I've started
to convert all settings to netlink while still allowing sysfs as fallback.

v4:
* last patch (which adds the netlink implementation of the settings commands)
  was splitted in 16 separate patches
* Cc the (most likely) responsible developers for each setting to more
  directly ask them for feedback
v3:
* fix kernel-doc in batman_adv.h
* add three patches to use the netlink interface with the already existing
  setting commands
v2:
* drop of generic config command
* reimplementation of the event command

Kind regards,
	Sven

Sven Eckelmann (20):
  batctl: Add support for config mcast group in event monitor
  batctl: Don't allocate new buffer for vlan parent device
  batctl: Automatically translate vlan to mesh_iface
  batctl: Add settings_data hooks for netlink integration
  batctl: Parse the arguments for gw_mode
  batctl: Add netlink simple query helper
  batctl: Support generic netlink for gw_mode command
  batctl: Support generic netlink for loglevel command
  batctl: Support generic netlink for isolation_mark command
  batctl: Support generic netlink for orig_interval command
  batctl: Add helper to read/write boolean configuration values
  batctl: Support generic netlink for aggregation command
  batctl: Support generic netlink for ap_isolation command
  batctl: Support generic netlink for bonding command
  batctl: Support generic netlink for bridge_loop_avoidance command
  batctl: Support generic netlink for distributed_arp_table command
  batctl: Support generic netlink for fragmentation command
  batctl: Support generic netlink for multicast_mode command
  batctl: Support generic netlink for network_coding command
  batctl: Drop settings_date param lists

 aggregation.c           |  45 ++++-
 ap_isolation.c          |  67 ++++++-
 batman_adv.h            | 188 +++++++++++++++++-
 bonding.c               |  45 ++++-
 bridge_loop_avoidance.c |  46 ++++-
 distributed_arp_table.c |  46 ++++-
 event.c                 | 234 ++++++++++++++++++++++
 fragmentation.c         |  45 ++++-
 functions.c             | 160 +++++++++++++---
 functions.h             |  23 ++-
 gateways.c              |  10 +-
 gw_mode.c               | 416 +++++++++++++++++++++++++++++++---------
 isolation_mark.c        | 123 +++++++++++-
 loglevel.c              | 138 ++++++++++---
 main.c                  |  10 +-
 main.h                  |   6 +-
 mcast_flags.c           |  10 +-
 multicast_mode.c        |  45 ++++-
 netlink.c               | 108 ++++++++++-
 netlink.h               |   2 +
 network_coding.c        |  45 ++++-
 orig_interval.c         |  84 +++++++-
 originators.c           |  10 +-
 routing_algo.c          |   1 -
 sys.c                   | 219 ++++++++++++++++-----
 sys.h                   |  25 ++-
 26 files changed, 1895 insertions(+), 256 deletions(-)

Comments

Linus Lüssing Jan. 7, 2019, 6:57 p.m. UTC | #1
On Fri, Dec 07, 2018 at 09:31:49PM +0100, Sven Eckelmann wrote:
> As mentioned earlier, the netlink config restructuring in batctl will be
> splitted in multiple steps. The first step was already merged and the
> RFC changes for the netlink interface in batman-adv were just posted.
> 
> The batman-adv weren't directly rejected by Jiro and thus I've started
> to convert all settings to netlink while still allowing sysfs as fallback.
> 

Is "batctl if" supposed to use netlink to get the interface status
yet?

Currently, with the items in *_attr[] in sysfs.c in batman-adv
commented out, I get these errors:

---
root@Linus-Debian:~# batctl if
ens3: <error reading status>
ens5: <error reading status>
---
Sven Eckelmann Jan. 8, 2019, 7:37 a.m. UTC | #2
On Monday, 7 January 2019 19.57.13 CET Linus Lüssing wrote:
[...]
> Is "batctl if" supposed to use netlink to get the interface status
> yet?
> 
> Currently, with the items in *_attr[] in sysfs.c in batman-adv
> commented out, I get these errors:
> 
> ---
> root@Linus-Debian:~# batctl if
> ens3: <error reading status>
> ens5: <error reading status>
> ---

Not yet, but I think we should switch to it in the near future.

Kind regards,
	Sven