From patchwork Mon Dec 2 05:05:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Linus_L=C3=BCssing?= X-Patchwork-Id: 21 Return-Path: X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from diktynna.open-mesh.org (localhost [IPv6:::1]) by diktynna.open-mesh.org (Postfix) with ESMTP id 5E12983F27 for ; Mon, 2 Dec 2024 06:35:48 +0100 (CET) ARC-Seal: i=2; cv=pass; a=rsa-sha256; d=open-mesh.org; s=20121; t=1733117748; b=JYmi/vAKZ+75Xn+E4+D3wAsiSRcetbHTndXaHQwxhdGvmfOmcdw3OTmilDKGl0kyZ1taj XhOD2pwDKBPhyneysjQUZCoC1Gy/OS0Iim4ToDRV+JmgZ0SJJdUXXyzGa+u3mxlD1luWT7D 7S9eiWaH4I3PRCr325IH2wqmPYtGc6I= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=open-mesh.org; s=20121; t=1733117748; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=XwL1pSGM62PjHCSuko99NLsiBUmZtSw2AbNJlwrlimo=; b=YmkhOFEEMe+eG7P3nbHu4e+2Z7zYh/UqebrOnPSbjSqNnNkkBWN1I+lim4LZX4uoloRZb ECGrC3QhnnM+1xxgAdYuL8aDl/VRY/2Izn+87w9iXJdpz3U+z9mhEednaJTg194ylHidVee CSc+/F04vUmzFtrPg6WzXGWpkTLzz4c= ARC-Authentication-Results: i=2; open-mesh.org; dkim=fail; arc=pass; dmarc=none Authentication-Results: open-mesh.org; dkim=fail; arc=pass; dmarc=none Received: from mail.aperture-lab.de (mail.aperture-lab.de [116.203.183.178]) by diktynna.open-mesh.org (Postfix) with ESMTPS id 746CF81CDD for ; Mon, 2 Dec 2024 06:35:20 +0100 (CET) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=open-mesh.org; s=20121; t=1733117720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=XwL1pSGM62PjHCSuko99NLsiBUmZtSw2AbNJlwrlimo=; b=2rxpEeiDM9bUHsKOFmsgitkcqlCBHpq4IgTmGSuB69zLM80O25Cl6LH7Zg8EjdsMhfS4Fj hmB7yus7fpPGu/xorx5i1JQlkzZ5DsucrRIV6H9OsYqRfuSN/EuS69JNrrZzZYdLUj1cM6 Hsa1H1FEBtcfoG3CuVpFaIaa01DOsjY= ARC-Seal: i=1; s=20121; d=open-mesh.org; t=1733117720; a=rsa-sha256; cv=none; b=F0mj4bwNUtBZSzON/HaGiSfd0NirDrN7RvJ/ColIaqHnDlv71xoeNgEaZbEYF/5eCmAQJ3 3VKesH+hEXruOCxIq3XIdYkvS7fNhCarUYBAdbjr8BjhKgNwJSvGMBfFWTVa+Gu77vvTv0 07tY4QTcmT8ov6dHEG5ynHh6h2lleo4= ARC-Authentication-Results: i=1; diktynna.open-mesh.org; dkim=none; spf=pass (diktynna.open-mesh.org: domain of linus.luessing@c0d3.blue designates 116.203.183.178 as permitted sender) smtp.mailfrom=linus.luessing@c0d3.blue; dmarc=none Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6DDD4541073 for ; Mon, 2 Dec 2024 06:35:19 +0100 (CET) From: =?utf-8?q?Linus_L=C3=BCssing?= To: b.a.t.m.a.n@lists.open-mesh.org Subject: [PATCH v3 0/3] add dynamic, bridged-in TT VID detection support Date: Mon, 2 Dec 2024 06:05:19 +0100 Message-ID: <20241202053511.326-1-linus.luessing@c0d3.blue> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Message-ID-Hash: T6J7CYQXRJMX2RYANC7LKHHV6KHL5NI2 X-Message-ID-Hash: T6J7CYQXRJMX2RYANC7LKHHV6KHL5NI2 X-MailFrom: linus.luessing@c0d3.blue X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-b.a.t.m.a.n.lists.open-mesh.org-0; header-match-b.a.t.m.a.n.lists.open-mesh.org-1; header-match-b.a.t.m.a.n.lists.open-mesh.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For one thing the following patchest is supposed to mitigate the regression of extra OGM overhead that we accidentally introduced with the introduction of the compatibility version 15, the TVLV support it provided, together with TT VLAN support. The addition of these TVLVs roughly doubled the OGM overhead back then, also/mainly because the 8021q and Linux bridge modules would add TT VLAN IDs 0 and 1, even if no one is actually using them. PATCH 3/3 tries to avoid this and will only add these two VLAN IDs if they were detected on actual traffic. In preparation of this the internal VLAN creation was overhauled in PATCH 1/3. This also in theory allows detecting new VLAN IDs dynamically from traffic from bridged-in traffic. So far, VLAN IDs could only be used which were anticipated and configured on top of bat0 by the administrator. However the detection of VLANs from bridged-in clients is by default disabled for now through PATCH 2/3. This patch adds a configurable limit for such snooped VLAN IDs, defaulting to zero for now. The issue is that each added VLAN still increases the OGM size considerably in the current protocol, so it is not advised to add many VLANs at the moment, without a bigger upgrade of the protocol. Also there is still an outstanding issue with temporarily broken broadcast traffic upon adding a new VLAN if BLA is enabled at the same time. Therefore defaulting to zero snooped VLANs from bridged-in clients for now. Regards, Linus --- v3: * fixing refcounting, removing an unnecessary kref_get() in PATCH 1/3 * adding PATCH 2/3 + PATCH 3/3 * resubmitting without the RFC tag v2: fix a typo, a missing "to" in the commit message