diff mbox

[16/16] batman-adv: add kernel-doc for enum batadv_dbg_level

Message ID !&!AAAAAAAAAAAYAAAAAAAAAOJK0u4CH31Kl5v1RPAzyrZCgQAAEAAAAKjiaB1rjc5LlgmOWy8Wfa0BAAAAAA==@gmail.com (mailing list archive)
State Rejected, archived
Headers

Commit Message

Walter Robert Ditzler Oct. 28, 2012, 1:32 p.m. UTC 
  hi batman list,

i recently saw there is a bounce of email in the batman community regarding
patches. is it safe and reliable to use the version from the open-mesh.org
site:

- inux 3.6 => batman-adv 2012.3.x (get batctl 2012.3.x from here)

for production use onto the following configuration:

os: debian 6.0.6
kernel: 3.6.3, batman activated
arch: geode lx and amd64

thanks for a brief answer.

walter

-----Original Message-----
From: B.A.T.M.A.N [mailto:b.a.t.m.a.n-bounces@lists.open-mesh.org] On Behalf
Of Antonio Quartulli
Sent: Sonntag, 28. Oktober 2012 12:17
To: davem@davemloft.net
Cc: netdev@vger.kernel.org; b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH 16/16] batman-adv: add kernel-doc for enum
batadv_dbg_level

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
 net/batman-adv/main.h | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

Comments

Sven Eckelmann Oct. 28, 2012, 2:33 p.m. UTC | #1 
On Sunday 28 October 2012 14:32:46 Walter Robert Ditzler wrote:
> hi batman list,
> 
> i recently saw there is a bounce of email in the batman community regarding
> patches.

Please don't reply to a random posts to start a new topic. And don't write to 
the Linux networking mailing list and the Linux networking maintainer David S. 
Miller when you actually want to ask the "b.a.t.m.a.n mailing list".

And yes, you will see patches going over this list the whole time. Either 
because somebody wants to get stuff integrated into some B.A.T.M.A.N. related 
project or because the patches were sent to our Linux networking god David S. 
Miller.

So nothing unusal happened.

> is it safe and reliable to use the version from the open-mesh.org
> site:
> 
> - inux 3.6 => batman-adv 2012.3.x (get batctl 2012.3.x from here)

Ehrm, ehrm, ehrm, ehrm, oehm, aehm.... I will not guarantee anything. It is 
safe to use this stuff until anyone proofed it otherwise. But we have some 
fixes in the maint branch which weren't released yet in form of 2012.3.1 or 
2012.4.0. But they are included in the stable releases of Linux 3.6.x

> for production use onto the following configuration:
> 
> os: debian 6.0.6
> kernel: 3.6.3, batman activated
> arch: geode lx and amd64

Now you baffled me completely. Linux 3.6.3 is the stable release which 
includes batman-adv 2012.3.0 + stable fixes. And you want to replace it with 
2012.3.0 without these stable fixes. Can you give me a reason why this sounded 
to you like a good idea? Even without these stable fixes... why would you 
replace the in-kernel module with the out-of-tree module of the same version?

Kind regards,
	Sven
diff mbox

Patch

diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index
9b94f05..897ba6a 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -165,12 +165,19 @@  int batadv_algo_register(struct batadv_algo_ops
*bat_algo_ops);  int batadv_algo_select(struct batadv_priv *bat_priv, char
*name);  int batadv_algo_seq_print_text(struct seq_file *seq, void *offset);
 
-/* all messages related to routing / flooding / broadcasting / etc */
+/**
+ * enum batadv_dbg_level - available log levels
+ * @BATADV_DBG_BATMAN: OGM and TQ computations related messages
+ * @BATADV_DBG_ROUTES: route added / changed / deleted
+ * @BATADV_DBG_TT: translation table messages
+ * @BATADV_DBG_BLA: bridge loop avoidance messages
+ * @BATADV_DBG_ALL: the union of all the above log levels  */
 enum batadv_dbg_level {
 	BATADV_DBG_BATMAN = BIT(0),
-	BATADV_DBG_ROUTES = BIT(1), /* route added / changed / deleted */
-	BATADV_DBG_TT	  = BIT(2), /* translation table operations */
-	BATADV_DBG_BLA    = BIT(3), /* bridge loop avoidance */
+	BATADV_DBG_ROUTES = BIT(1),
+	BATADV_DBG_TT	  = BIT(2),
+	BATADV_DBG_BLA    = BIT(3),
 	BATADV_DBG_ALL    = 15,
 };
 
--
1.7.12.4