From patchwork Thu Dec 10 19:00:57 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Eckelmann X-Patchwork-Id: 5182 Return-Path: Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by open-mesh.net (Postfix) with SMTP id C3B4A15423E for ; Thu, 10 Dec 2009 19:46:41 +0000 (UTC) Received: (qmail invoked by alias); 10 Dec 2009 19:01:48 -0000 Received: from i59F6BCE1.versanet.de (EHLO localhost) [89.246.188.225] by mail.gmx.net (mp052) with SMTP; 10 Dec 2009 20:01:48 +0100 X-Authenticated: #15668376 X-Provags-ID: V01U2FsdGVkX1/UZYQwK+/UMd7BFEOW5u0B9iUWFAkBgYh+JXUb+u hdrTlpB8xzA7B/ From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.net Date: Thu, 10 Dec 2009 20:00:57 +0100 Message-Id: <1260471657-25962-1-git-send-email-sven.eckelmann@gmx.de> X-Mailer: git-send-email 1.6.5.4 X-Y-GMX-Trusted: 0 X-FuHaFi: 0.62 Subject: [B.A.T.M.A.N.] [PATCH] [batman-adv] Remove NULL pointer check before calling kfree X-BeenThere: b.a.t.m.a.n@lists.open-mesh.net X-Mailman-Version: 2.1.11 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2009 19:46:42 -0000 It is safe to call kfree(NULL) which makes this extra check unneeded. It was found using checkpatch.pl from linux-2.6 Signed-off-by: Sven Eckelmann --- batman-adv-kernelland/hard-interface.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/batman-adv-kernelland/hard-interface.c b/batman-adv-kernelland/hard-interface.c index e9cb977..28d02f6 100644 --- a/batman-adv-kernelland/hard-interface.c +++ b/batman-adv-kernelland/hard-interface.c @@ -399,8 +399,7 @@ int hardif_add_interface(char *dev, int if_num) return 1; out: - if (batman_if->packet_buff) - kfree(batman_if->packet_buff); + kfree(batman_if->packet_buff); kfree(batman_if); kfree(dev); return -1;