diff mbox

batman-adv: remove all rcu head initializations

Message ID 1274014932-2792-1-git-send-email-sven.eckelmann@gmx.de
State Superseded, archived
Commit e50ec86732a343fdeb0bc321f036e75e31ddf047
Headers show

Commit Message

Sven Eckelmann May 16, 2010, 1:02 p.m. UTC
From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Remove all rcu head inits. We don't care about the RCU head state before
passing it to call_rcu() anyway. Only leave the "on_stack" variants so
debugobjects can keep track of objects on stack.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Cc: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
I've tried to check if the initialisation was always done in call_rcu in all
implementations since 2.6.21. This assumption seems to be correct. I've
already applied it to the maint branch and it must only be applied to the

 hard-interface.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff mbox


diff --git a/hard-interface.c b/hard-interface.c
index c17ad85..bc2bd12 100644
--- a/hard-interface.c
+++ b/hard-interface.c
@@ -341,7 +341,6 @@  static struct batman_if *hardif_add_interface(struct net_device *net_dev)
 	batman_if->if_num = -1;
 	batman_if->net_dev = net_dev;
 	batman_if->if_status = IF_NOT_IN_USE;
-	INIT_RCU_HEAD(&batman_if->rcu);