diff mbox

[v2] batman-adv: remove all rcu head initializations

Message ID 1274090330-22874-1-git-send-email-sven.eckelmann@gmx.de
State Accepted, archived
Headers show

Commit Message

Sven Eckelmann May 17, 2010, 9:58 a.m. UTC 
From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Remove all rcu head inits. We don't care about the RCU head state before
passing it to call_rcu() anyway. Only leave the "on_stack" variants so
debugobjects can keep track of objects on stack.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Cc: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
---
I've tried to check if the initialisation was always done in call_rcu in all
implementations since 2.6.21. This assumption seems to be correct. I've
already applied it to the maint branch and it must only be applied to the
trunk.

v2: I've accidently send the version of maint instead the version for trunk.
There were no real differences, but the paths.

 batman-adv-kernelland/hard-interface.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Marek Lindner May 17, 2010, 1:58 p.m. UTC | #1 
On Monday 17 May 2010 17:58:50 Sven Eckelmann wrote:
> From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> 
> Remove all rcu head inits. We don't care about the RCU head state before
> passing it to call_rcu() anyway. Only leave the "on_stack" variants so
> debugobjects can keep track of objects on stack.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
> Cc: Marek Lindner <lindner_marek@yahoo.de>
> Cc: Sven Eckelmann <sven.eckelmann@gmx.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>

Ok, applied in revision 1659.

Thanks,
Marek
diff mbox

Patch

diff --git a/batman-adv-kernelland/hard-interface.c b/batman-adv-kernelland/hard-interface.c
index 5123176..cc7fbae 100644
--- a/batman-adv-kernelland/hard-interface.c
+++ b/batman-adv-kernelland/hard-interface.c
@@ -341,7 +341,6 @@  static struct batman_if *hardif_add_interface(struct net_device *net_dev)
 	batman_if->if_num = -1;
 	batman_if->net_dev = net_dev;
 	batman_if->if_status = IF_NOT_IN_USE;
-	INIT_RCU_HEAD(&batman_if->rcu);
 	INIT_LIST_HEAD(&batman_if->list);
 
 	check_known_mac_addr(batman_if->net_dev->dev_addr);