From patchwork Mon May 17 09:58:50 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Eckelmann X-Patchwork-Id: 139 Return-Path: Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by open-mesh.net (Postfix) with SMTP id DDC981541FF for ; Mon, 17 May 2010 06:35:05 +0200 (CEST) Received: (qmail invoked by alias); 17 May 2010 09:58:51 -0000 Received: from i59F6BF99.versanet.de (EHLO sven-desktop.lazhur.ath.cx) [89.246.191.153] by mail.gmx.net (mp069) with SMTP; 17 May 2010 11:58:51 +0200 X-Authenticated: #15668376 X-Provags-ID: V01U2FsdGVkX18c3tNONqscVrWb1UHgLBALqMUcu/rf7dmRopRzmC d+pL3FHTzUeLEL From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.org Date: Mon, 17 May 2010 11:58:50 +0200 Message-Id: <1274090330-22874-1-git-send-email-sven.eckelmann@gmx.de> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1274014932-2792-1-git-send-email-sven.eckelmann@gmx.de> References: <1274014932-2792-1-git-send-email-sven.eckelmann@gmx.de> X-Y-GMX-Trusted: 0 Subject: [B.A.T.M.A.N.] [PATCHv2] batman-adv: remove all rcu head initializations X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2010 04:35:06 -0000 From: Paul E. McKenney Remove all rcu head inits. We don't care about the RCU head state before passing it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can keep track of objects on stack. Signed-off-by: Mathieu Desnoyers Signed-off-by: Paul E. McKenney Cc: Andrew Lunn Cc: Simon Wunderlich Cc: Marek Lindner Cc: Sven Eckelmann Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sven Eckelmann --- I've tried to check if the initialisation was always done in call_rcu in all implementations since 2.6.21. This assumption seems to be correct. I've already applied it to the maint branch and it must only be applied to the trunk. v2: I've accidently send the version of maint instead the version for trunk. There were no real differences, but the paths. batman-adv-kernelland/hard-interface.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/batman-adv-kernelland/hard-interface.c b/batman-adv-kernelland/hard-interface.c index 5123176..cc7fbae 100644 --- a/batman-adv-kernelland/hard-interface.c +++ b/batman-adv-kernelland/hard-interface.c @@ -341,7 +341,6 @@ static struct batman_if *hardif_add_interface(struct net_device *net_dev) batman_if->if_num = -1; batman_if->net_dev = net_dev; batman_if->if_status = IF_NOT_IN_USE; - INIT_RCU_HEAD(&batman_if->rcu); INIT_LIST_HEAD(&batman_if->list); check_known_mac_addr(batman_if->net_dev->dev_addr);