From patchwork Sun Jun 6 19:03:04 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Eckelmann X-Patchwork-Id: 218 Return-Path: Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by open-mesh.net (Postfix) with SMTP id 882531543A1 for ; Sun, 6 Jun 2010 21:03:45 +0200 (CEST) Received: (qmail invoked by alias); 06 Jun 2010 19:03:43 -0000 Received: from i59F6A425.versanet.de (EHLO sven-desktop.lazhur.ath.cx) [89.246.164.37] by mail.gmx.net (mp010) with SMTP; 06 Jun 2010 21:03:43 +0200 X-Authenticated: #15668376 X-Provags-ID: V01U2FsdGVkX1/PCCVSepvPZFqqfHI/YSJUCN/JmGl4mLyVA4c2M5 J+PE9+CtbUYIwj From: Sven Eckelmann To: gregkh@suse.de, b.a.t.m.a.n@lists.open-mesh.net Date: Sun, 6 Jun 2010 21:03:04 +0200 Message-Id: <1275850985-27105-2-git-send-email-sven.eckelmann@gmx.de> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1275850985-27105-1-git-send-email-sven.eckelmann@gmx.de> References: <1275850985-27105-1-git-send-email-sven.eckelmann@gmx.de> X-Y-GMX-Trusted: 0 Cc: Dan Carpenter Subject: [B.A.T.M.A.N.] [PATCH 1/2] Staging: batman-adv: return -EFAULT on copy_to_user errors X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2010 19:03:45 -0000 From: Dan Carpenter copy_to_user() returns the number of bites remaining but we want to return a negative error code here. Signed-off-by: Dan Carpenter Signed-off-by: Sven Eckelmann --- drivers/staging/batman-adv/device.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/batman-adv/device.c b/drivers/staging/batman-adv/device.c index 7eb6559..32204b5 100644 --- a/drivers/staging/batman-adv/device.c +++ b/drivers/staging/batman-adv/device.c @@ -196,7 +196,7 @@ ssize_t bat_device_read(struct file *file, char __user *buf, size_t count, kfree(device_packet); if (error) - return error; + return -EFAULT; return sizeof(struct icmp_packet); }