From patchwork Sun Sep 12 21:21:54 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Eckelmann X-Patchwork-Id: 376 Return-Path: Received: from mail.gmx.net (mailout-de.gmx.net [213.165.64.22]) by open-mesh.net (Postfix) with SMTP id C94F2154496 for ; Sun, 12 Sep 2010 23:21:33 +0200 (CEST) Received: (qmail invoked by alias); 12 Sep 2010 21:21:33 -0000 Received: from i59F6B2E6.versanet.de (EHLO sven-desktop.lazhur.ath.cx) [89.246.178.230] by mail.gmx.net (mp012) with SMTP; 12 Sep 2010 23:21:33 +0200 X-Authenticated: #15668376 X-Provags-ID: V01U2FsdGVkX1+CHod+oMmCZhgbY7MY6Zxv/mHCpkOElmyGiYcVLd 4HBMeH5lDIVpRh From: Sven Eckelmann To: greg@kroah.com Date: Sun, 12 Sep 2010 23:21:54 +0200 Message-Id: <1284326516-30540-4-git-send-email-sven.eckelmann@gmx.de> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1284326516-30540-1-git-send-email-sven.eckelmann@gmx.de> References: <1284326516-30540-1-git-send-email-sven.eckelmann@gmx.de> X-Y-GMX-Trusted: 0 Cc: b.a.t.m.a.n@lists.open-mesh.net Subject: [B.A.T.M.A.N.] [PATCH 3/5] Staging: batman-adv: Add rcu TODO X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2010 21:21:34 -0000 Paul E. McKenney informed us that rcu is misused by leaking pointers to rcu related elements outside read-side protected critical sections. He also recommended that it should be checked against the rcu checklist. Signed-off-by: Sven Eckelmann --- drivers/staging/batman-adv/TODO | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/staging/batman-adv/TODO b/drivers/staging/batman-adv/TODO index 1457c7f..3af8028 100644 --- a/drivers/staging/batman-adv/TODO +++ b/drivers/staging/batman-adv/TODO @@ -1,3 +1,8 @@ + * Rework usage of RCU + - don't leak pointers from rcu out of rcu critical area which may + get freed + - check were synchronize_rcu must be used + - go through Documentation/RCU/checklist.txt * Request a new review * Process the comments from the review * Move into mainline proper