diff mbox

batman-adv: remove obsolete flags variable to avoid kernel warnings

Message ID 1287846695-17402-1-git-send-email-lindner_marek@yahoo.de (mailing list archive)
State Accepted, archived
Headers

Commit Message

Marek Lindner Oct. 23, 2010, 3:11 p.m. UTC 
  Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
 batman-adv/bat_debugfs.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

Sven Eckelmann Oct. 23, 2010, 3:19 p.m. UTC | #1 
Marek Lindner wrote:
> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> ---
>  batman-adv/bat_debugfs.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/batman-adv/bat_debugfs.c b/batman-adv/bat_debugfs.c
> index 11e5f65..934c879 100644
> --- a/batman-adv/bat_debugfs.c
> +++ b/batman-adv/bat_debugfs.c
> @@ -57,7 +57,6 @@ static int fdebug_log(struct debug_log *debug_log, char
> *fmt, ...) va_list args;
>  	static char debug_log_buf[256];
>  	char *p;
> -	unsigned long flags;
> 
>  	if (!debug_log)
>  		return 0;
> @@ -113,7 +112,6 @@ static ssize_t log_read(struct file *file, char __user
> *buf, struct debug_log *debug_log = bat_priv->debug_log;
>  	int error, i = 0;
>  	char c;
> -	unsigned long flags;
> 
>  	if ((file->f_flags & O_NONBLOCK) &&
>  	    !(debug_log->log_end - debug_log->log_start))

Correct. Forgot them because I only build it in non-debug mode.

Acked-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Marek Lindner Oct. 23, 2010, 3:21 p.m. UTC | #2 
On Saturday 23 October 2010 17:19:21 Sven Eckelmann wrote:
> Correct. Forgot them because I only build it in non-debug mode.

Same here - I missed these warnings when I checked your patch before 
submitting it. Just applied this patch (revision 1848).

Regards,
Marek
diff mbox

Patch

diff --git a/batman-adv/bat_debugfs.c b/batman-adv/bat_debugfs.c
index 11e5f65..934c879 100644
--- a/batman-adv/bat_debugfs.c
+++ b/batman-adv/bat_debugfs.c
@@ -57,7 +57,6 @@  static int fdebug_log(struct debug_log *debug_log, char *fmt, ...)
 	va_list args;
 	static char debug_log_buf[256];
 	char *p;
-	unsigned long flags;
 
 	if (!debug_log)
 		return 0;
@@ -113,7 +112,6 @@  static ssize_t log_read(struct file *file, char __user *buf,
 	struct debug_log *debug_log = bat_priv->debug_log;
 	int error, i = 0;
 	char c;
-	unsigned long flags;
 
 	if ((file->f_flags & O_NONBLOCK) &&
 	    !(debug_log->log_end - debug_log->log_start))