diff mbox

[v2,2/2] batman-adv: Fix imbalanced locking in gw_node_update

Message ID 1301641248-6710-1-git-send-email-sven@narfation.org (mailing list archive)
State Superseded, archived
Headers

Commit Message

Sven Eckelmann April 1, 2011, 7 a.m. UTC 
  8ffdea813e32cee3c60be36fb9e6a5e077e51ea0 used rcu_read_unlock without
using rcu_read_lock when gw_get_selected_gw_node didn't return a valid
gw_node.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
Maybe the other patch is useful in the future... but changing the goto
to a return is less invasive and easier to understand

 gateway_client.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff mbox

Patch

diff --git a/gateway_client.c b/gateway_client.c
index 3d0050b..fff998a 100644
--- a/gateway_client.c
+++ b/gateway_client.c
@@ -312,7 +312,7 @@  void gw_node_update(struct bat_priv *bat_priv,
 
 	curr_gw = gw_get_selected_gw_node(bat_priv);
 	if (!curr_gw)
-		goto out;
+		return;
 
 	rcu_read_lock();
 	hlist_for_each_entry_rcu(gw_node, node, &bat_priv->gw_list, list) {