diff mbox

batman-adv: correct !x & y in !(x & y)

Message ID 1306621577-5494-1-git-send-email-ordex@autistici.org (mailing list archive)
State Accepted, archived
Commit a726fdad131019166a46bace12da4653c1a592b3
Headers

Commit Message

Antonio Quartulli May 28, 2011, 10:26 p.m. UTC 
  This error was introduced with: 4dea0274b8edeab50bfeb6685ef33362e3ec9299

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
This error has been found using sparse

 translation-table.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Sven Eckelmann May 29, 2011, 6:31 a.m. UTC | #1 
On Sunday 29 May 2011 00:26:17 Antonio Quartulli wrote:
> This error was introduced with: 4dea0274b8edeab50bfeb6685ef33362e3ec9299
> 
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>

An extrem large and loud

Acked-by: Sven Eckelmann <sven@narfation.org>

And to the Acked-by: Simon Wunderlich <...> stuff in the tt patch. Marek 
submitted a version which was modified a lot in the last minute and I would 
doubt that Simon found time to do all his tests. Still this line remained....

Kind regards,
	Sven
Marek Lindner May 29, 2011, 11:58 a.m. UTC | #2 
On Sunday 29 May 2011 08:31:41 Sven Eckelmann wrote:
> On Sunday 29 May 2011 00:26:17 Antonio Quartulli wrote:
> > This error was introduced with: 4dea0274b8edeab50bfeb6685ef33362e3ec9299
> > 
> > Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> 
> An extrem large and loud
> 
> Acked-by: Sven Eckelmann <sven@narfation.org>

Applied in revision a726fda


> And to the Acked-by: Simon Wunderlich <...> stuff in the tt patch. Marek
> submitted a version which was modified a lot in the last minute and I would
> doubt that Simon found time to do all his tests. Still this line
> remained....

Yes, I did not check the commit message again. 
Please don't add these "Acked-by" statements. I'll add them prior to the 
commit if applicable. 

Thanks,
Marek
diff mbox

Patch

diff --git a/translation-table.c b/translation-table.c
index 464569e..f0d8857 100644
--- a/translation-table.c
+++ b/translation-table.c
@@ -724,7 +724,7 @@  static void tt_global_roam_purge(struct bat_priv *bat_priv)
 		spin_lock_bh(list_lock);
 		hlist_for_each_entry_safe(tt_global_entry, node, node_tmp,
 					  head, hash_entry) {
-			if (!tt_global_entry->flags & TT_GLOBAL_ROAM)
+			if (!(tt_global_entry->flags & TT_GLOBAL_ROAM))
 				continue;
 			if (!is_out_of_time(tt_global_entry->roam_at,
 					    TT_GLOBAL_ROAM_TIMEOUT * 1000))