[v2] batman-adv: request the full table if tt_crc doesn't match
Commit Message
In case of tt_crc mismatching for a certain orig_node after applying the
changes, the node must request the full table immediately.
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
Comment rephrased.
routing.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
Comments
On Thursday, July 07, 2011 14:24:34 Antonio Quartulli wrote:
> In case of tt_crc mismatching for a certain orig_node after applying the
> changes, the node must request the full table immediately.
Applied in revision 33184a1.
Thanks,
Marek
@@ -91,6 +91,18 @@ static void update_transtable(struct bat_priv *bat_priv,
* to recompute it to spot any possible inconsistency
* in the global table */
orig_node->tt_crc = tt_global_crc(bat_priv, orig_node);
+
+ /* The ttvn alone is not enough to guarantee consistency
+ * because the a single value could repesent different states
+ * (due to the wrap around). Thus a node has to check whether
+ * the table resulting (after applying the changes) is still
+ * consistent or not. E.g. a node could disconnect while its
+ * ttvn is X and reconnect on ttvn = X + TTVN_MAX: in this case
+ * checking the CRC value is mandatory to detect the
+ * inconsistency */
+ if (orig_node->tt_crc != tt_crc)
+ goto request_table;
+
/* Roaming phase is over: tables are in sync again. I can
* unset the flag */
orig_node->tt_poss_change = false;