mbox

pull request: batman-adv 2011-08-24

Message ID 1314190838-2273-1-git-send-email-lindner_marek@yahoo.de
State Not Applicable, archived
Headers show

Pull-request

git://git.open-mesh.org/linux-merge.git batman-adv/next

Message

Marek Lindner Aug. 24, 2011, 1 p.m. UTC
Hi,

the following 8 patches constitute the first batch I'd like to get the pulled
into net-next-2.6/3.2. They bring a new feature (AP isolation on the mesh
layer), some minor cleanups, spelling fixes and some additional debugfs 
output. 

Thanks,
Marek


The following changes since commit 322a8b034003c0d46d39af85bf24fee27b902f48:

  Linux 3.1-rc1 (2011-08-07 18:23:30 -0700)

are available in the git repository at:
  git://git.open-mesh.org/linux-merge.git batman-adv/next

Antonio Quartulli (6):
      batman-adv: hash_add() has to discriminate on the return value
      batman-adv: correct several typ0s in the comments
      batman-adv: detect clients connected through a 802.11 device
      batman-adv: implement AP-isolation on the receiver side
      batman-adv: implement AP-isolation on the sender side
      batman-adv: print client flags in the local/global transtables output

Marek Lindner (2):
      batman-adv: reuse tt_len() to calculate tt buffer length
      batman-adv: merge update_transtable() into tt related code

 Documentation/ABI/testing/sysfs-class-net-mesh |    8 +
 net/batman-adv/aggregation.h                   |    3 +-
 net/batman-adv/bat_sysfs.c                     |    2 +
 net/batman-adv/bitarray.c                      |    6 +-
 net/batman-adv/gateway_client.c                |   10 +-
 net/batman-adv/hard-interface.c                |   34 ++++-
 net/batman-adv/hard-interface.h                |    1 +
 net/batman-adv/hash.h                          |   25 +++-
 net/batman-adv/main.c                          |    2 +-
 net/batman-adv/main.h                          |    6 +-
 net/batman-adv/originator.c                    |    2 +-
 net/batman-adv/packet.h                        |    1 +
 net/batman-adv/routing.c                       |   77 +--------
 net/batman-adv/send.c                          |   10 +-
 net/batman-adv/soft-interface.c                |   13 +-
 net/batman-adv/translation-table.c             |  199 ++++++++++++++++++++----
 net/batman-adv/translation-table.h             |   21 ++--
 net/batman-adv/types.h                         |    5 +-
 net/batman-adv/unicast.c                       |    6 +-
 net/batman-adv/unicast.h                       |    2 +-
 net/batman-adv/vis.c                           |    6 +-
 21 files changed, 291 insertions(+), 148 deletions(-)

Comments

David Miller Aug. 24, 2011, 5:35 p.m. UTC | #1
From: Marek Lindner <lindner_marek@yahoo.de>
Date: Wed, 24 Aug 2011 15:00:30 +0200

> the following 8 patches constitute the first batch I'd like to get the pulled
> into net-next-2.6/3.2. They bring a new feature (AP isolation on the mesh
> layer), some minor cleanups, spelling fixes and some additional debugfs 
> output. 
...
>   git://git.open-mesh.org/linux-merge.git batman-adv/next

Pulled, thanks.
Jon Roland Aug. 24, 2011, 7:21 p.m. UTC | #2
The effort presented at http://thelifenetwork.org/ seems to be a
realization of much of what the BATMAN project is about. Comments?

-- Jon

----------------------------------------------------------
Linux Migration Net             http://linux-migration.net
2900 W Anderson Ln C-200-322              Austin, TX 78757
512/299-5001                   jroland@linux-migration.net
----------------------------------------------------------
Sven Eckelmann Aug. 24, 2011, 9:21 p.m. UTC | #3
First some comment about your mail: Please don't reply to random threads to
start a new topic.

On Wed, Aug 24, 2011 at 02:21:47PM -0500, Jon Roland wrote:
> The effort presented at http://thelifenetwork.org/ seems to be a
> realization of much of what the BATMAN project is about. Comments?

I don't know what you are actually asking.

Lifenet is not B.A.T.M.A.N. advanced (it uses some ideas also present in
batman-adv) and has a complete different background [1].

I scrolled through their code [2] and would recommend them to read some books
about parallel programming [3] and a good lecture about kernel programming (not
that I am good in it, but they are even worse).

Kind regards,
	Sven

[1] http://conferences.sigcomm.org/sigcomm/2011/papers/sigcomm/p446.pdf
[2] https://github.com/hrushim/LifeNet
[3] http://kernel.org/pub/linux/kernel/people/paulmck/perfbook/perfbook.html
Jon Roland Aug. 24, 2011, 9:51 p.m. UTC | #4
Your comments are just what I hoped to get. There seems to be an
explosion of independent efforts in this field that are presently not
talking to one another. It might benefit us all if there was more of a
mesh among meshers.

On 08/24/2011 04:21 PM, Sven Eckelmann wrote:
> I don't know what you are actually asking.
>
> Lifenet is not B.A.T.M.A.N. advanced (it uses some ideas also present in
> batman-adv) and has a complete different background [1].
>
> I scrolled through their code [2] and would recommend them to read some books
> about parallel programming [3] and a good lecture about kernel programming (not
> that I am good in it, but they are even worse).
>
> Kind regards,
> 	Sven
>
> [1] http://conferences.sigcomm.org/sigcomm/2011/papers/sigcomm/p446.pdf
> [2] https://github.com/hrushim/LifeNet
> [3] http://kernel.org/pub/linux/kernel/people/paulmck/perfbook/perfbook.html


-- Jon

----------------------------------------------------------
Linux Migration Net             http://linux-migration.net
2900 W Anderson Ln C-200-322              Austin, TX 78757
512/299-5001                   jroland@linux-migration.net
----------------------------------------------------------
Marek Lindner Aug. 24, 2011, 11:22 p.m. UTC | #5
On Wednesday, August 24, 2011 23:51:09 Jon Roland wrote:
> Your comments are just what I hoped to get. There seems to be an
> explosion of independent efforts in this field that are presently not
> talking to one another. It might benefit us all if there was more of a
> mesh among meshers.

Actually, we try to fill that communication gap with the yearly wireless 
battle mesh[1] gatherings. I hope you can reserve some time for it to present 
your project there.

Cheers,
Marek

[1] http://battlemesh.org/
Santosh S Vempala Aug. 25, 2011, 12:03 a.m. UTC | #6
Sven:
Thanks for scrolling through the code. Have you actually tried it? Do you have any improvements to suggest? (even if you're not an expert at kernel programming)
-SV

----- Original Message -----
> Your comments are just what I hoped to get. There seems to be an
> explosion of independent efforts in this field that are presently not
> talking to one another. It might benefit us all if there was more of a
> mesh among meshers.
> 
> On 08/24/2011 04:21 PM, Sven Eckelmann wrote:
> > I don't know what you are actually asking.
> >
> > Lifenet is not B.A.T.M.A.N. advanced (it uses some ideas also
> > present in
> > batman-adv) and has a complete different background [1].
> >
> > I scrolled through their code [2] and would recommend them to read
> > some books
> > about parallel programming [3] and a good lecture about kernel
> > programming (not
> > that I am good in it, but they are even worse).
> >
> > Kind regards,
> > 	Sven
> >
> > [1]
> > http://conferences.sigcomm.org/sigcomm/2011/papers/sigcomm/p446.pdf
> > [2] https://github.com/hrushim/LifeNet
> > [3]
> > http://kernel.org/pub/linux/kernel/people/paulmck/perfbook/perfbook.html
> 
> 
> -- Jon
> 
> ----------------------------------------------------------
> Linux Migration Net http://linux-migration.net
> 2900 W Anderson Ln C-200-322 Austin, TX 78757
> 512/299-5001 jroland@linux-migration.net
> ----------------------------------------------------------
Sven Eckelmann Aug. 25, 2011, 5:51 a.m. UTC | #7
On Wed, Aug 24, 2011 at 08:03:41PM -0400, Santosh S Vempala wrote:
> Sven:
> Thanks for scrolling through the code. Have you actually tried it? Do you have any improvements to suggest? (even if you're not an expert at kernel programming)

I will _not_ try to use the code before the obvious problems aren't solved
(make it thread safe, don't access memory and then check if it was good to
access them, don't implement your own linked list, general error checking,
don't clutter up proc, fix skb handling/checking in general, ...).

But don't understand me wrong. I think it is not a good implementation, but the
idea itself is interesting and I would like a real paper/journal article about
it. I know that there are at least two other papers available [1,2], but only
one [2] is linked at your site. So maybe they don't show your current ideas...
but I will read both of them later in the train.

I personally don't understand Jon Roland's comments. It is good that research
is done in this field and also that people think about different goals they
want to achieve. And I would also aggree with Marek that it would be
interesting to show your results at small mesh related meetings like Wireless
Battle of the Mesh (not real to "battle against other meshes", but to exchange
some information). But be aware that the worst participant is eaten by wild
animals ;) (just look through the pictures of WBMv4[3]).

Kind regards,
	Sven

[1] http://conferences.sigcomm.org/hotnets/2007/papers/hotnets6-final57.pdf
[2] http://dritte.org/nsdr09/files/nsdr09_camera/s4p2_paranjpe09nsdr.pdf
[3] http://battlemesh.org/BattleMeshV4/Pictures
Sven Eckelmann Aug. 26, 2011, 8:14 p.m. UTC | #8
On Friday 26 August 2011 15:32:37 Hrushi Mehendale wrote:
> Hi Sven,
> 
> Thank you very much for your frank comments about the code.

Another comment about your mail: Don't send html to the mailing list... it 
will be dropped.

> Hopefully, with help from experienced programmers such as you and many
> others whom we may not even know, we would be able to improve the code
> quality. The prototype is just out of our research lab and as you pointed
> out, the code needs to be fine tuned now. Apart from building the prototype,
> majority of our efforts have been spent on porting LifeNet across different
> hardware and OS platforms, in order to validate our baseline claims of
> hardware and OS interoperability.

I doubt that it has something to do with fine tuning. There are just simple 
things which you should not do: For example accessing memory after you free'd 
the memory region.

> Do you have any suggestions for us to facilitate better interaction with the
> community, particularly to make sure LifeNet adhers to best programming
> practices / standards?

A nasty comment would be: learn coding

But honestly, you should get in contact with good kernel programmer which can 
work for you. It is not a "community" thing, but understanding what you are 
actually doing. I think those papers are a good example. You seem to 
understand your problem and try to find a solution. But the problem is that 
you are not the persons which understand the actual implementation stuff. So 
maybe there is a operating system department at your university which has 
experienced people and can help to implement your ideas.

Not that I have a problem with research code... but selling it to 
organisations and knowing that it has ugly bugs seems not to be a good idea 
(at least from my point of view).

Kind regards,
	Sven
Sven Eckelmann Aug. 26, 2011, 10:35 p.m. UTC | #9
On Friday 26 August 2011 22:14:02 Sven Eckelmann wrote:
> > Do you have any suggestions for us to facilitate better interaction with
> > the community, particularly to make sure LifeNet adhers to best
> > programming practices / standards?
> 
> A nasty comment would be: learn coding

Just to make it not sound sooo bad (everybody tells me that I am evil and that 
I should not write such things). Don't take it to seriously, but I am just not 
able to accept those things as "fine tuning". And it is hard to give hints 
about "best programming practices" when it is obviously not a best programming 
practice thing.

And again: I don't attack your research, but the code I saw doesn't work as 
expected.

Kind regards,
	Sven
Outback Dingo Aug. 27, 2011, 1:37 a.m. UTC | #10
On Fri, Aug 26, 2011 at 6:35 PM, Sven Eckelmann <sven@narfation.org> wrote:
>
> On Friday 26 August 2011 22:14:02 Sven Eckelmann wrote:
> > > Do you have any suggestions for us to facilitate better interaction with
> > > the community, particularly to make sure LifeNet adhers to best
> > > programming practices / standards?
> >
> > A nasty comment would be: learn coding
>
> Just to make it not sound sooo bad (everybody tells me that I am evil and that
> I should not write such things). Don't take it to seriously, but I am just not
> able to accept those things as "fine tuning". And it is hard to give hints
> about "best programming practices" when it is obviously not a best programming
> practice thing.
>
> And again: I don't attack your research, but the code I saw doesn't work as
> expected.
>
> Kind regards,
>        Sven

Even worse, requires ant and java to even build.... i mean seriously?
there are so many of these "projects" popping up all with similiar goals,
best case scenerios are a coalition of like minds working to an end result
Sven Eckelmann Aug. 27, 2011, 8:21 a.m. UTC | #11
On Friday 26 August 2011 21:37:29 Outback Dingo wrote:
[...]
> Even worse, requires ant and java to even build.... i mean seriously?
> there are so many of these "projects" popping up all with similiar goals,
> best case scenerios are a coalition of like minds working to an end result

Why is it a problem to require java and ant? Both have free (osi definition) 
implementations. And I am personally a big fan of build systems to manage 
complex tasks.

And I heavily disagree with the idea of one project that will be better than 
all other projects (for germans: eierlegende Wollmilchsau). We have to accept 
that there are many problems out there and some of them should be solved by 
different algorithms.

Kind regards,
	Sven