| Message ID | 1321261892-6401-1-git-send-email-bug-track@fisher-privat.net |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Monday 14 November 2011 10:11:32 Alexey Fisher wrote: > Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net> > --- > Makefile | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/Makefile b/Makefile > index 5762721..44bad88 100644 > --- a/Makefile > +++ b/Makefile > @@ -42,3 +42,6 @@ all: > > clean: > $(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) clean > + > +install: > + @cp batman-adv.ko $(shell dirname > $(KERNELPATH))/kernel/net/batman-adv/batman-adv.ko NAck: Sven Eckelmann <sven@narfation.org> Please read in the current linux sources Documentation/kbuild/modules.txt +install + $(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) modules_install or to override the old version that is included in the kernel +install + $(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) INSTALL_MOD_DIR=kernel/net/batman-adv/ modules_install Kind regards, Sven
On 14.11.2011 10:38, Sven Eckelmann wrote: > On Monday 14 November 2011 10:11:32 Alexey Fisher wrote: >> Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net> >> --- >> Makefile | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 5762721..44bad88 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -42,3 +42,6 @@ all: >> >> clean: >> $(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) clean >> + >> +install: >> + @cp batman-adv.ko $(shell dirname >> $(KERNELPATH))/kernel/net/batman-adv/batman-adv.ko > > NAck: Sven Eckelmann <sven@narfation.org> > > Please read in the current linux sources Documentation/kbuild/modules.txt > > +install > + $(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) modules_install > > or to override the old version that is included in the kernel > > +install > + $(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) INSTALL_MOD_DIR=kernel/net/batman-adv/ modules_install Thank you, so you will send your patch? I prefer last version, to make testing easier. regards, Alexey.
On Monday 14 November 2011 10:38:07 Sven Eckelmann wrote: > On Monday 14 November 2011 10:11:32 Alexey Fisher wrote: > > Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net> > > --- > > > > Makefile | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) [...] > NAck: Sven Eckelmann <sven@narfation.org> And also "Nack" for not updating the README [1] Kind regards, Sven [1] http://www.open-mesh.org/wiki/open-mesh/Contribute#Submitting-patches
On Monday 14 November 2011 11:19:19 Alexey Fisher wrote: [...] > Thank you, > so you will send your patch? I prefer last version, to make testing easier. I personally don't care. Feel free to fix your patch and send a new version (but think about adding the ":" after "install" -- the character magically disappeared when I wrote the mail). And don't forget the documentation part as it is always hard to remember everything on the day the release is made, but easy when you just made the patch. :) Thanks, Sven
diff --git a/Makefile b/Makefile index 5762721..44bad88 100644 --- a/Makefile +++ b/Makefile @@ -42,3 +42,6 @@ all: clean: $(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) clean + +install: + @cp batman-adv.ko $(shell dirname $(KERNELPATH))/kernel/net/batman-adv/batman-adv.ko
Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net> --- Makefile | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)