From patchwork Sun Dec 4 20:01:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Lindner X-Patchwork-Id: 1432 Return-Path: Received: from nm3-vm0.bullet.mail.ukl.yahoo.com (nm3-vm0.bullet.mail.ukl.yahoo.com [217.146.183.228]) by open-mesh.org (Postfix) with SMTP id 31D4760086D for ; Sun, 4 Dec 2011 21:01:59 +0100 (CET) Authentication-Results: open-mesh.org; dkim=pass (1024-bit key) header.i=@yahoo.de; dkim-adsp=none Received: from [217.146.183.181] by nm3.bullet.mail.ukl.yahoo.com with NNFMP; 04 Dec 2011 20:01:58 -0000 Received: from [77.238.184.61] by tm12.bullet.mail.ukl.yahoo.com with NNFMP; 04 Dec 2011 20:01:58 -0000 Received: from [127.0.0.1] by smtp130.mail.ukl.yahoo.com with NNFMP; 04 Dec 2011 20:01:58 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s1024; t=1323028918; bh=qgaGsUdCItnMzrl2OF0Z9UT2a8FeyWJyiDxeTKeVzKo=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer; b=BNJd1AnW4v5vGtc3ypIFTGsqfgmxIzOZkynnf7yuCjL6jpnudhAy1cNk8ucyittokUQqQp54dE2eMSUVsS4pm4+v0YhL34VLxU3n189X+v33EaZojau2p7bRjOQ87QKrdMyNwAQOtDOG9uGVJRjbxZ2LJXiUdpOzMgGTPpWL/ow= X-Yahoo-Newman-Id: 887673.96224.bm@smtp130.mail.ukl.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: ZwcqJsoVM1kv8vKGRyy6b1X59qQBMP7lAxN2ckV8To1Crle hVkCGy915bAqTfZvMfyZPB1FzpDoEpM7OJ8LsFWDwkqh_.bspDzvcANpvmwc wCf.2RtIuhnGiQQvWFLWMRj6HoQ9s9huzCXkM.GoX.gBGyHASY1X41TIS3e3 MlPl2YDS3MhxtBzqT9t2xmnKOZrp2EgmB_AHgBbATzGwLccgR3eJ8S3qXYOc ZmU_Xz1K_TuB9caI48eV_Fd38Pp8D_G0_R7mj5_LSzYq4vimhLsfM9Cwy7g6 PjMz6GAYxI8RKmxs9FH1AbN8jPgU6rBO7la0HhC3Jb2GbV9.mJJnQbXJyZqn Q8d3GPTf5cEE0ysHDoZOhOPx_YpeGGH9qGqRnVKSZKunuVOc0XdQbopI- X-Yahoo-SMTP: tW.h3tiswBBMXO2coYcbPigGD5Lt6zY_.Zc- Received: from localhost (lindner_marek@210.177.7.38 with plain) by smtp130.mail.ukl.yahoo.com with SMTP; 04 Dec 2011 20:01:57 +0000 GMT From: Marek Lindner To: b.a.t.m.a.n@lists.open-mesh.org Date: Mon, 5 Dec 2011 04:01:51 +0800 Message-Id: <1323028911-13495-1-git-send-email-lindner_marek@yahoo.de> X-Mailer: git-send-email 1.7.5.4 Cc: Marek Lindner Subject: [B.A.T.M.A.N.] [PATCH] batman-adv: simplify bat_ogm_receive API call X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Dec 2011 20:01:59 -0000 Most of the values in that call are derived from the skb, so we can hand over the skb instead. Reported-by: Simon Wunderlich Signed-off-by: Marek Lindner --- bat_iv_ogm.c | 11 +++++++---- bat_ogm.h | 3 +-- routing.c | 4 +--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c index d60e1ba..3402fa5 100644 --- a/bat_iv_ogm.c +++ b/bat_iv_ogm.c @@ -1140,13 +1140,16 @@ out: orig_node_free_ref(orig_node); } -void bat_ogm_receive(const struct ethhdr *ethhdr, unsigned char *packet_buff, - int packet_len, struct hard_iface *if_incoming) +void bat_ogm_receive(struct hard_iface *if_incoming, struct sk_buff *skb) { struct batman_ogm_packet *batman_ogm_packet; - int buff_pos = 0; - unsigned char *tt_buff; + struct ethhdr *ethhdr; + int buff_pos = 0, packet_len; + unsigned char *tt_buff, *packet_buff; + packet_len = skb_headlen(skb); + ethhdr = (struct ethhdr *)skb_mac_header(skb); + packet_buff = skb->data; batman_ogm_packet = (struct batman_ogm_packet *)packet_buff; /* unpack the aggregated packets and process them one by one */ diff --git a/bat_ogm.h b/bat_ogm.h index 69329c1..47edfde 100644 --- a/bat_ogm.h +++ b/bat_ogm.h @@ -29,7 +29,6 @@ void bat_ogm_init_primary(struct hard_iface *hard_iface); void bat_ogm_update_mac(struct hard_iface *hard_iface); void bat_ogm_schedule(struct hard_iface *hard_iface, int tt_num_changes); void bat_ogm_emit(struct forw_packet *forw_packet); -void bat_ogm_receive(const struct ethhdr *ethhdr, unsigned char *packet_buff, - int packet_len, struct hard_iface *if_incoming); +void bat_ogm_receive(struct hard_iface *if_incoming, struct sk_buff *skb); #endif /* _NET_BATMAN_ADV_OGM_H_ */ diff --git a/routing.c b/routing.c index 4363d19..5bc41c8 100644 --- a/routing.c +++ b/routing.c @@ -272,9 +272,7 @@ int recv_bat_ogm_packet(struct sk_buff *skb, struct hard_iface *hard_iface) if (skb_linearize(skb) < 0) return NET_RX_DROP; - ethhdr = (struct ethhdr *)skb_mac_header(skb); - - bat_ogm_receive(ethhdr, skb->data, skb_headlen(skb), hard_iface); + bat_ogm_receive(hard_iface, skb); kfree_skb(skb); return NET_RX_SUCCESS;