| Message ID | 1324377504-20983-1-git-send-email-lindner_marek@yahoo.de |
|---|---|
| State | Not Applicable, archived |
| Headers |
Return-Path: <lindner_marek@yahoo.de> Received: from nm6.bullet.mail.ukl.yahoo.com (nm6.bullet.mail.ukl.yahoo.com [217.146.182.227]) by open-mesh.org (Postfix) with SMTP id D74D360026D for <b.a.t.m.a.n@lists.open-mesh.org>; Tue, 20 Dec 2011 11:38:31 +0100 (CET) Authentication-Results: open-mesh.org; dkim=pass (1024-bit key) header.i=@yahoo.de; dkim-adsp=none Received: from [217.146.183.183] by nm6.bullet.mail.ukl.yahoo.com with NNFMP; 20 Dec 2011 10:38:31 -0000 Received: from [77.238.184.74] by tm14.bullet.mail.ukl.yahoo.com with NNFMP; 20 Dec 2011 10:38:31 -0000 Received: from [127.0.0.1] by smtp143.mail.ukl.yahoo.com with NNFMP; 20 Dec 2011 10:38:31 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s1024; t=1324377511; bh=FTt93MwDYPcbOZccvsbta65IajgcAyI4ftCzrP45kSA=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer; b=S8/y1MWMzPqeCGuiW3tSqwaoX4uMHSV/FZIoSioI3ebU3ur1ykH53qmqRDLsrH5tHW5T5MrvOBd4fIenBRTkM1XBku8wZHE6gEn+mQrRe6E2l4UT3ZY5FMOFp0TcY+6ZVTzEhYIZcDybzdOwSjm+zx7C/WeNvqHFbX/eTLkLMv0= X-Yahoo-Newman-Id: 497381.3392.bm@smtp143.mail.ukl.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 7p_3p2YVM1npjJkl.PXobfLa.cta49y8paUQZ_YNQfruVAb qvnMrMz3u_SrTWcJIxCcglOWnyAH6xvoMCshs2A50Wzusgxd._taKmfI.rPW lokUptNpPR3Ck3k9SMy8iiNaX6ubhHUMj1Rm4zRsjvyWJTYiz8I27hckt0b4 PtS9K2dDNzN6X5tnPtM0U4BrTUm.6PzuFbtvEg5SS5v7tkvQq1NDlrkEDlKe qHOlPe1l_NVQ4d7EPRb5YZLX1uVV4frF0TQA8LVeJpNb3NDTa19Wjgs4vr_j G.emsIAEGpHEEPHa5uktXkTg836XaASIjaHSrO7KK6grIi1kdjzm6GQZpB2k gL5xZ39AQCbp1jCerqSao3b58OApHESab3QnCyFL90xBwPjM8 X-Yahoo-SMTP: tW.h3tiswBBMXO2coYcbPigGD5Lt6zY_.Zc- Received: from localhost (lindner_marek@217.85.82.213 with plain) by smtp143.mail.ukl.yahoo.com with SMTP; 20 Dec 2011 10:38:30 +0000 GMT From: Marek Lindner <lindner_marek@yahoo.de> To: davem@davemloft.net Date: Tue, 20 Dec 2011 18:38:24 +0800 Message-Id: <1324377504-20983-1-git-send-email-lindner_marek@yahoo.de> X-Mailer: git-send-email 1.7.5.4 Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, Marek Lindner <lindner_marek@yahoo.de> Subject: [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org> List-Id: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n.lists.open-mesh.org> List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe> List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n> List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org> List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help> List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe> X-List-Received-Date: Tue, 20 Dec 2011 10:38:32 -0000 |
Commit Message
Marek Lindner
Dec. 20, 2011, 10:38 a.m. UTC
The long line was introduced with b26e478f8f.
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
net/batman-adv/translation-table.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Comments
From: Marek Lindner <lindner_marek@yahoo.de> Date: Tue, 20 Dec 2011 18:38:24 +0800 > The long line was introduced with b26e478f8f. > > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de> I'm not applying this. I tell people to make sure arguments line up correctly to the openning parenthesis on the previous line, and that is what is happening here.
On Wednesday, December 21, 2011 02:32:30 David Miller wrote: > From: Marek Lindner <lindner_marek@yahoo.de> > Date: Tue, 20 Dec 2011 18:38:24 +0800 > > > The long line was introduced with b26e478f8f. > > > > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de> > > I'm not applying this. > > I tell people to make sure arguments line up correctly to the > openning parenthesis on the previous line, and that is what is > happening here. I am not against lining up the arguments but what about checkpatch ? Are we going to ignore the complaints or is this line limit about to be changed ? Cheers, Marek
From: Marek Lindner <lindner_marek@yahoo.de> Date: Wed, 21 Dec 2011 02:59:41 +0800 > On Wednesday, December 21, 2011 02:32:30 David Miller wrote: >> From: Marek Lindner <lindner_marek@yahoo.de> >> Date: Tue, 20 Dec 2011 18:38:24 +0800 >> >> > The long line was introduced with b26e478f8f. >> > >> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de> >> >> I'm not applying this. >> >> I tell people to make sure arguments line up correctly to the >> openning parenthesis on the previous line, and that is what is >> happening here. > > I am not against lining up the arguments but what about checkpatch ? Are we > going to ignore the complaints or is this line limit about to be changed ? Refactor the code so that both constraints can be satisfied. Is this so hard to understand?
On Wednesday, December 21, 2011 03:02:09 David Miller wrote: > From: Marek Lindner <lindner_marek@yahoo.de> > Date: Wed, 21 Dec 2011 02:59:41 +0800 > > > On Wednesday, December 21, 2011 02:32:30 David Miller wrote: > >> From: Marek Lindner <lindner_marek@yahoo.de> > >> Date: Tue, 20 Dec 2011 18:38:24 +0800 > >> > >> > The long line was introduced with b26e478f8f. > >> > > >> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de> > >> > >> I'm not applying this. > >> > >> I tell people to make sure arguments line up correctly to the > >> openning parenthesis on the previous line, and that is what is > >> happening here. > > > > I am not against lining up the arguments but what about checkpatch ? Are > > we going to ignore the complaints or is this line limit about to be > > changed ? > > Refactor the code so that both constraints can be satisfied. > > Is this so hard to understand? Well, my crystal ball did not unveil that a checkpatch complaint you silently introduced would mean somebody else has to refactor the code. Guess I have to get a replacement unit. Cheers, Marek
On Wed, 2011-12-21 at 03:15 +0800, Marek Lindner wrote: > On Wednesday, December 21, 2011 03:02:09 David Miller wrote: > > From: Marek Lindner <lindner_marek@yahoo.de> > > Date: Wed, 21 Dec 2011 02:59:41 +0800 > > > > > On Wednesday, December 21, 2011 02:32:30 David Miller wrote: > > >> From: Marek Lindner <lindner_marek@yahoo.de> > > >> Date: Tue, 20 Dec 2011 18:38:24 +0800 > > >> > > >> > The long line was introduced with b26e478f8f. > > >> > > > >> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de> > > >> > > >> I'm not applying this. > > >> > > >> I tell people to make sure arguments line up correctly to the > > >> openning parenthesis on the previous line, and that is what is > > >> happening here. > > > > > > I am not against lining up the arguments but what about checkpatch ? Are > > > we going to ignore the complaints or is this line limit about to be > > > changed ? > > > > Refactor the code so that both constraints can be satisfied. > > > > Is this so hard to understand? > > Well, my crystal ball did not unveil that a checkpatch complaint you silently > introduced would mean somebody else has to refactor the code. Guess I have to > get a replacement unit. No-one has to refactor the code. I think David's point is that he's more concerned about proper alignment than having every line under 80 characters. If you want to satisfy the latter constraint, you still have to satisfy the former. Ben.
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index ab8dea8..58361ed 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -679,7 +679,7 @@ void tt_global_del(struct bat_priv *bat_priv, * 2) the client roamed to us => we can directly delete * the global entry, since it is useless now. */ tt_local_entry = tt_local_hash_find(bat_priv, - tt_global_entry->common.addr); + tt_global_entry->common.addr); if (!tt_local_entry) { tt_global_entry->common.flags |= TT_CLIENT_ROAM; tt_global_entry->roam_at = jiffies;