diff mbox

[v2] batctl: exit on parse error in batctl ll

Message ID 1327257063-13289-1-git-send-email-siwu@hrz.tu-chemnitz.de (mailing list archive)
State Accepted, archived
Headers

Commit Message

Simon Wunderlich Jan. 22, 2012, 6:31 p.m. UTC 
  If the argument could not be understood, we should not try to
apply something, but return from the function.

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
---
 sys.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

Comments

Marek Lindner Jan. 26, 2012, 7:47 p.m. UTC | #1 
On Monday, January 23, 2012 02:31:03 Simon Wunderlich wrote:
> If the argument could not be understood, we should not try to
> apply something, but return from the function.

Applied in revision b320bf2.

Thanks,
Marek
diff mbox

Patch

diff --git a/sys.c b/sys.c
index 9cdccba..56f55dd 100644
--- a/sys.c
+++ b/sys.c
@@ -221,8 +221,11 @@  int handle_loglevel(char *mesh_iface, int argc, char **argv)
 				log_level |= (1 << 1);
 			else if (strcmp(argv[i], "tt") == 0)
 				log_level |= (1 << 2);
-			else
+			else {
 				log_level_usage();
+				res = EXIT_FAILURE;
+				goto out;
+			}
 		}
 
 		snprintf(str, sizeof(str), "%i", log_level);