From patchwork Tue Feb 28 11:32:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Lindner X-Patchwork-Id: 1568 Return-Path: Received: from nm25-vm5.bullet.mail.ukl.yahoo.com (nm25-vm5.bullet.mail.ukl.yahoo.com [217.146.177.125]) by open-mesh.org (Postfix) with SMTP id AABB76008DC for ; Tue, 28 Feb 2012 12:36:31 +0100 (CET) Authentication-Results: open-mesh.org; dkim=pass (1024-bit key) header.i=@yahoo.de; dkim-adsp=none Received: from [217.146.183.213] by nm25.bullet.mail.ukl.yahoo.com with NNFMP; 28 Feb 2012 11:36:31 -0000 Received: from [217.146.182.185] by tm6.bullet.mail.ukl.yahoo.com with NNFMP; 28 Feb 2012 11:36:31 -0000 Received: from [127.0.0.1] by smtp108.mail.ukl.yahoo.com with NNFMP; 28 Feb 2012 11:36:31 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s1024; t=1330428991; bh=76PCkXAHgDQD9HvbuLarAO34SOCHsXpr6DOtK+GDn78=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer:In-Reply-To:References; b=oJ1/1tHyWSomwVf3o0of/wyjy5HBrcQSQyG+VRqESlyCVG39wAOqUGfguyIxctOoodCUu5YIANx0OKZIfNcrByj3hnncDjIpJfcWleR97DPfwo3VNwdjRSGnexKkN6xUFo8jRyv9o2rsl+9XXZ0wzBRHpN4vPKOr+ucvC5uAJ8M= X-Yahoo-Newman-Id: 291246.68598.bm@smtp108.mail.ukl.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: v45j6fMVM1mWZvnsUZnAHlZL1AYzike.9C0i9a_ZgglWAtz uqam0Lk5cT0N4.bmG_Dud.aS1Xet2gs.jm6vrK5ArodNf1aGfXSVC2FINEsz xoWNnswI1UUYcYph9WIeLNUErt6.ewmrzcMx_0Kb4osGAhkr1.nnNLaLbxkg 9URfF2UsaMyAfq5S0ckHHI8h6L8ilbUxnonAYNIR9ov92sMOI4M1jU.99UJm N612CMApNwkblyq_jWZ8MDvtZzg8hZSwARWvA4p4Yj2jsKRQo2ufod8rhlJ1 In6GDEirADO0fCD50vnDttuB8caRs42lT7GMGvMCcCsrejapODTgQa8tUKsv _C74f0mEyyPmKeO0TqeSQh2lM09dBHq7.iaJjQQuNBQsMcwLWYaGlU9j1rIM wNrXBZelyrQ0- X-Yahoo-SMTP: tW.h3tiswBBMXO2coYcbPigGD5Lt6zY_.Zc- Received: from localhost (lindner_marek@59.152.213.162 with plain) by smtp108.mail.ukl.yahoo.com with SMTP; 28 Feb 2012 03:36:30 -0800 PST From: Marek Lindner To: davem@davemloft.net Date: Tue, 28 Feb 2012 19:32:26 +0800 Message-Id: <1330428748-23137-7-git-send-email-lindner_marek@yahoo.de> X-Mailer: git-send-email 1.7.9 In-Reply-To: <1330428748-23137-1-git-send-email-lindner_marek@yahoo.de> References: <1330428748-23137-1-git-send-email-lindner_marek@yahoo.de> Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, Marek Lindner Subject: [B.A.T.M.A.N.] [PATCH 6/8] batman-adv: TT_CLIENT_PENDING is never set in struct tt_global_entry X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2012 11:36:31 -0000 From: Antonio Quartulli Actually the TT_CLIENT_PENDING flag is never set in the tt_global_entry structure, therefore this code is useless and can be removed. Reported-by: Simon Wunderlich Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner --- net/batman-adv/translation-table.c | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 1ff7fbe..9a6f315 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -603,7 +603,7 @@ int tt_global_seq_print_text(struct seq_file *seq, void *offset) struct tt_global_entry, common); seq_printf(seq, " * %pM (%3u) via %pM (%3u) " - "[%c%c%c]\n", + "[%c%c]\n", tt_global_entry->common.addr, tt_global_entry->ttvn, tt_global_entry->orig_node->orig, @@ -613,8 +613,6 @@ int tt_global_seq_print_text(struct seq_file *seq, void *offset) (tt_global_entry->common.flags & TT_CLIENT_ROAM ? 'R' : '.'), (tt_global_entry->common.flags & - TT_CLIENT_PENDING ? 'X' : '.'), - (tt_global_entry->common.flags & TT_CLIENT_WIFI ? 'W' : '.')); } rcu_read_unlock(); @@ -838,11 +836,6 @@ struct orig_node *transtable_search(struct bat_priv *bat_priv, if (!atomic_inc_not_zero(&tt_global_entry->orig_node->refcount)) goto out; - /* A global client marked as PENDING has already moved from that - * originator */ - if (tt_global_entry->common.flags & TT_CLIENT_PENDING) - goto out; - orig_node = tt_global_entry->orig_node; out: