batman-adv: select an internet gateway if none was chosen
Commit Message
This is a regression introduced by: 6a17ecc4603be7f065c38b288d038a0082bbf21d
Reported-by: Nicolás Echániz <nicoechaniz@codigosur.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
This patch is intended for next and needs to be backported for stable.
gateway_client.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Comments
On Mon, Jul 23, 2012 at 02:59:13PM +0200, Marek Lindner wrote:
> This is a regression introduced by: 6a17ecc4603be7f065c38b288d038a0082bbf21d
>
> Reported-by: Nicolás Echániz <nicoechaniz@codigosur.org>
> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> ---
Thank you Marek for fixing bugs that I silently introduce :)
Acked-by: Antonio Quartulli <ordex@autistici.org>
On Monday, July 23, 2012 19:33:56 Antonio Quartulli wrote:
> On Mon, Jul 23, 2012 at 02:59:13PM +0200, Marek Lindner wrote:
> > This is a regression introduced by:
> > 6a17ecc4603be7f065c38b288d038a0082bbf21d
> >
> >
> >
> > Reported-by: Nicolás Echániz <nicoechaniz@codigosur.org>
> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> > ---
>
> Thank you Marek for fixing bugs that I silently introduce :)
>
> Acked-by: Antonio Quartulli <ordex@autistici.org>
Applied in revision 8c379dc.
Regards,
Marek
@@ -200,11 +200,11 @@ void batadv_gw_election(struct batadv_priv *bat_priv)
if (atomic_read(&bat_priv->gw_mode) != BATADV_GW_MODE_CLIENT)
goto out;
- if (!batadv_atomic_dec_not_zero(&bat_priv->gw_reselect))
- goto out;
-
curr_gw = batadv_gw_get_selected_gw_node(bat_priv);
+ if (!batadv_atomic_dec_not_zero(&bat_priv->gw_reselect) && curr_gw)
+ goto out;
+
next_gw = batadv_gw_get_best_gw_node(bat_priv);
if (curr_gw == next_gw)