diff mbox

batman-adv: Add dummy soft-interface rx mode handler

Message ID 1369516631-11982-1-git-send-email-linus.luessing@web.de (mailing list archive)
State Superseded, archived
Headers

Commit Message

Linus Lüssing May 25, 2013, 9:17 p.m. UTC 
  We do not actually need to set any rx filters for the virtual batman
soft interface. However a dummy handler enables a user to set static
multicast listeners for instance.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
---
* Fixes issue #171


 soft-interface.c |    5 +++++
 1 file changed, 5 insertions(+)

Comments

Antonio Quartulli May 25, 2013, 9:44 p.m. UTC | #1 
On Sat, May 25, 2013 at 11:17:11PM +0200, Linus Lüssing wrote:
> We do not actually need to set any rx filters for the virtual batman
> soft interface. However a dummy handler enables a user to set static
> multicast listeners for instance.
> 
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
> ---
> * Fixes issue #171

Thank you Linus for digging into this.
I've seen that the bridge code does the very same thing.

Cheers,
Marek Lindner May 25, 2013, 10:08 p.m. UTC | #2 
On Sunday, May 26, 2013 05:17:11 Linus Lüssing wrote:
> diff --git a/soft-interface.c b/soft-interface.c
> index 2bad57f..e40e74f 100644
> --- a/soft-interface.c
> +++ b/soft-interface.c
> @@ -137,6 +137,10 @@ static int batadv_interface_change_mtu(struct
> net_device *dev, int new_mtu) return 0;
>  }
>  
> +static void batadv_interface_set_rx_mode(struct net_device *dev)
> +{
> +}

For the kernel doc I suggest to stress the point that we only add this dummy 
handler to make multicast listeners possible.

Cheers,
Marek
diff mbox

Patch

diff --git a/soft-interface.c b/soft-interface.c
index 2bad57f..e40e74f 100644
--- a/soft-interface.c
+++ b/soft-interface.c
@@ -137,6 +137,10 @@  static int batadv_interface_change_mtu(struct net_device *dev, int new_mtu)
 	return 0;
 }
 
+static void batadv_interface_set_rx_mode(struct net_device *dev)
+{
+}
+
 static int batadv_interface_tx(struct sk_buff *skb,
 			       struct net_device *soft_iface)
 {
@@ -572,6 +576,7 @@  static const struct net_device_ops batadv_netdev_ops = {
 	.ndo_get_stats = batadv_interface_stats,
 	.ndo_set_mac_address = batadv_interface_set_mac_addr,
 	.ndo_change_mtu = batadv_interface_change_mtu,
+	.ndo_set_rx_mode = batadv_interface_set_rx_mode,
 	.ndo_start_xmit = batadv_interface_tx,
 	.ndo_validate_addr = eth_validate_addr,
 	.ndo_add_slave = batadv_softif_slave_add,