diff mbox

batman-adv: (style) fix for switched vid-ifiindex parameter order

Message ID 1371203642-2224-1-git-send-email-linus.luessing@web.de (mailing list archive)
State Superseded, archived
Commit cc14598eabfbe26e2cb62a435da786e5c6f5fd4b
Headers

Commit Message

Linus Lüssing June 14, 2013, 9:54 a.m. UTC 
  batadv_tt_local_add() first takes the vid and then the interface index
parameter. One of these calls had the order switched.

However in this case it is not a functional, but just a style fix
because at the moment BATADV_NO_FLAGS is equal to BATADV_NULL_IFINDEX.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
---
 main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Antonio Quartulli June 14, 2013, 12:49 p.m. UTC | #1 
Hey Linus,

On Fri, Jun 14, 2013 at 11:54:02AM +0200, Linus Lüssing wrote:
> batadv_tt_local_add() first takes the vid and then the interface index
> parameter. One of these calls had the order switched.
> 
> However in this case it is not a functional, but just a style fix
> because at the moment BATADV_NO_FLAGS is equal to BATADV_NULL_IFINDEX.
> 

Thanks for fixing this :)

However, can you please resend this patch adding the commit id and the subject
of the change introducing this problem? This will help me in squashing the
original patch and this fix before sending the patches upstream.
(Sorry for annoying with this :-))

> Signed-off-by: Linus Lüssing <linus.luessing@web.de>

You can also add

Acked-by: Antonio Quartulli <ordex@autistici.org>

Cheers,

> ---
>  main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/main.c b/main.c
> index f2f1137..a7ad6cb 100644
> --- a/main.c
> +++ b/main.c
> @@ -128,7 +128,7 @@ int batadv_mesh_init(struct net_device *soft_iface)
>  		goto err;
>  
>  	batadv_tt_local_add(soft_iface, soft_iface->dev_addr,
> -			    BATADV_NULL_IFINDEX, BATADV_NO_FLAGS);
> +			    BATADV_NO_FLAGS, BATADV_NULL_IFINDEX);
>  
>  	ret = batadv_bla_init(bat_priv);
>  	if (ret < 0)
> -- 
> 1.7.10.4
diff mbox

Patch

diff --git a/main.c b/main.c
index f2f1137..a7ad6cb 100644
--- a/main.c
+++ b/main.c
@@ -128,7 +128,7 @@  int batadv_mesh_init(struct net_device *soft_iface)
 		goto err;
 
 	batadv_tt_local_add(soft_iface, soft_iface->dev_addr,
-			    BATADV_NULL_IFINDEX, BATADV_NO_FLAGS);
+			    BATADV_NO_FLAGS, BATADV_NULL_IFINDEX);
 
 	ret = batadv_bla_init(bat_priv);
 	if (ret < 0)