diff mbox

[v2] batman-adv: (style) fix for switched vid-ifiindex parameter order

Message ID 1371233050-7938-1-git-send-email-linus.luessing@web.de (mailing list archive)
State Accepted, archived
Headers

Commit Message

Linus Lüssing June 14, 2013, 6:04 p.m. UTC 
  batadv_tt_local_add() first takes the vid and then the interface index
parameter. One of these calls had the order switched.

However in this case it is not a functional, but just a style fix
because at the moment BATADV_NO_FLAGS is equal to BATADV_NULL_IFINDEX.

Introduced by 580d7919f19e4f73ccd79e82a532af2bdc638042
("batman-adv: add the VLAN ID attribute to the TT entry")

Acked-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
---
v2: Added "Introduced by..." to commit message

 main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Lindner June 19, 2013, 3:20 p.m. UTC | #1 
On Saturday, June 15, 2013 02:04:09 Linus Lüssing wrote:
> batadv_tt_local_add() first takes the vid and then the interface index
> parameter. One of these calls had the order switched.
> 
> However in this case it is not a functional, but just a style fix
> because at the moment BATADV_NO_FLAGS is equal to BATADV_NULL_IFINDEX.
> 
> Introduced by 580d7919f19e4f73ccd79e82a532af2bdc638042
> ("batman-adv: add the VLAN ID attribute to the TT entry")
> 
> Acked-by: Antonio Quartulli <ordex@autistici.org>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
> ---
> v2: Added "Introduced by..." to commit message
> 
>  main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied in revision cc14598.

Thanks,
Marek
diff mbox

Patch

diff --git a/main.c b/main.c
index f2f1137..a7ad6cb 100644
--- a/main.c
+++ b/main.c
@@ -128,7 +128,7 @@  int batadv_mesh_init(struct net_device *soft_iface)
 		goto err;
 
 	batadv_tt_local_add(soft_iface, soft_iface->dev_addr,
-			    BATADV_NULL_IFINDEX, BATADV_NO_FLAGS);
+			    BATADV_NO_FLAGS, BATADV_NULL_IFINDEX);
 
 	ret = batadv_bla_init(bat_priv);
 	if (ret < 0)