From patchwork Fri Jun 14 18:04:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Linus_L=C3=BCssing?= X-Patchwork-Id: 3190 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=212.227.15.3; helo=mout.web.de; envelope-from=linus.luessing@web.de; receiver=b.a.t.m.a.n@lists.open-mesh.org Received: from mout.web.de (mout.web.de [212.227.15.3]) by open-mesh.org (Postfix) with ESMTP id E0DF3602139 for ; Fri, 14 Jun 2013 20:04:11 +0200 (CEST) Received: from localhost ([46.246.36.155]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0M9ons-1Uca0I3TeS-00B3iE; Fri, 14 Jun 2013 20:04:11 +0200 From: =?UTF-8?q?Linus=20L=C3=BCssing?= To: b.a.t.m.a.n@lists.open-mesh.org Date: Fri, 14 Jun 2013 20:04:09 +0200 Message-Id: <1371233050-7938-1-git-send-email-linus.luessing@web.de> X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 X-Provags-ID: V03:K0:vnaZ3jhPNhRmMAU3XiWk9IcDOeDWd+F68fC8MoFWvZyTVQeCehe /1Xkl7qQ9+HZcf5kjhnbWH57KJgp0o+RAP5vrSQhyCk8r9ROCIatubZ4aKJ/XRLZRHf7dM8 He9kZrFyIFZW/j/JdR05RmppgP5yONCA1KWqyXLCqbCyvBcalehjShiPlQlFSliy/7LLQpL y1pL/+EKW1r9HN3+w5GUg== Subject: [B.A.T.M.A.N.] [PATCHv2] batman-adv: (style) fix for switched vid-ifiindex parameter order X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jun 2013 18:04:12 -0000 batadv_tt_local_add() first takes the vid and then the interface index parameter. One of these calls had the order switched. However in this case it is not a functional, but just a style fix because at the moment BATADV_NO_FLAGS is equal to BATADV_NULL_IFINDEX. Introduced by 580d7919f19e4f73ccd79e82a532af2bdc638042 ("batman-adv: add the VLAN ID attribute to the TT entry") Acked-by: Antonio Quartulli Signed-off-by: Linus Lüssing --- v2: Added "Introduced by..." to commit message main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.c b/main.c index f2f1137..a7ad6cb 100644 --- a/main.c +++ b/main.c @@ -128,7 +128,7 @@ int batadv_mesh_init(struct net_device *soft_iface) goto err; batadv_tt_local_add(soft_iface, soft_iface->dev_addr, - BATADV_NULL_IFINDEX, BATADV_NO_FLAGS); + BATADV_NO_FLAGS, BATADV_NULL_IFINDEX); ret = batadv_bla_init(bat_priv); if (ret < 0)