diff mbox

[3/4] batman-adv: fix sparse warning in batadv_iv_ogm_emit

Message ID 1385123427-15460-3-git-send-email-sw@simonwunderlich.de (mailing list archive)
State Accepted, archived
Commit a0fc2f129f7193cbdd7e9c2e4da0d6e7ac15dd58
Headers

Commit Message

Simon Wunderlich Nov. 22, 2013, 12:30 p.m. UTC 
  From: Simon Wunderlich <simon@open-mesh.com>

The directlink variable is not needed anymore, and sparse complains
about that. Remove it.

Removal was introduced in 29b9256e6631876d4f1719f4d5e13d7ee140c61b
("batman-adv: consider outgoing interface in OGM sending")

Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
---
 bat_iv_ogm.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Marek Lindner Nov. 22, 2013, 5:29 p.m. UTC | #1 
On Friday 22 November 2013 13:30:26 Simon Wunderlich wrote:
> From: Simon Wunderlich <simon@open-mesh.com>
> 
> The directlink variable is not needed anymore, and sparse complains
> about that. Remove it.
> 
> Removal was introduced in 29b9256e6631876d4f1719f4d5e13d7ee140c61b
> ("batman-adv: consider outgoing interface in OGM sending")
> 
> Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
> ---
>  bat_iv_ogm.c |    2 --
>  1 file changed, 2 deletions(-)

Applied in revision a0fc2f1.

Thanks,
Marek
diff mbox

Patch

diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c
index dbd55f0..2a36de8 100644
--- a/bat_iv_ogm.c
+++ b/bat_iv_ogm.c
@@ -467,12 +467,10 @@  static void batadv_iv_ogm_emit(struct batadv_forw_packet *forw_packet)
 	struct batadv_priv *bat_priv;
 	struct batadv_hard_iface *primary_if = NULL;
 	struct batadv_ogm_packet *batadv_ogm_packet;
-	unsigned char directlink;
 	uint8_t *packet_pos;
 
 	packet_pos = forw_packet->skb->data;
 	batadv_ogm_packet = (struct batadv_ogm_packet *)packet_pos;
-	directlink = (batadv_ogm_packet->flags & BATADV_DIRECTLINK ? 1 : 0);
 
 	if (!forw_packet->if_incoming) {
 		pr_err("Error - can't forward packet: incoming iface not specified\n");