diff mbox

[1/3] batman-adv: fix another sparse warning in batadv_iv_ogm_emit

Message ID 1385298345-13746-1-git-send-email-sw@simonwunderlich.de (mailing list archive)
State Accepted, archived
Commit 20978cae66114f4dce6ba7f9f980eadfccff8570
Headers

Commit Message

Simon Wunderlich Nov. 24, 2013, 1:05 p.m. UTC 
  From: Simon Wunderlich <simon@open-mesh.com>

Since the directlink variable was not needed anymore and was removed,
more variables are now obsolete too, so remove them.

The directlink flag commit (which was obviously incomplete) was
a0fc2f129f7193cbdd7e9c2e4da0d6e7ac15dd58 ("batman-adv: fix sparse warning
in batadv_iv_ogm_emit"), which itself was a fix for
29b9256e6631876d4f1719f4d5e13d7ee140c61b ("batman-adv: consider outgoing
interface in OGM sending").

Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
---
 bat_iv_ogm.c |    5 -----
 1 file changed, 5 deletions(-)

Comments

Marek Lindner Nov. 25, 2013, 5:48 p.m. UTC | #1 
On Sunday 24 November 2013 14:05:43 Simon Wunderlich wrote:
> From: Simon Wunderlich <simon@open-mesh.com>
> 
> Since the directlink variable was not needed anymore and was removed,
> more variables are now obsolete too, so remove them.
> 
> The directlink flag commit (which was obviously incomplete) was
> a0fc2f129f7193cbdd7e9c2e4da0d6e7ac15dd58 ("batman-adv: fix sparse warning
> in batadv_iv_ogm_emit"), which itself was a fix for
> 29b9256e6631876d4f1719f4d5e13d7ee140c61b ("batman-adv: consider outgoing
> interface in OGM sending").
> 
> Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
> ---
>  bat_iv_ogm.c |    5 -----
>  1 file changed, 5 deletions(-)

Applied in revision 20978ca.

Thanks,
Marek
diff mbox

Patch

diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c
index 92165cb..b9aec98 100644
--- a/bat_iv_ogm.c
+++ b/bat_iv_ogm.c
@@ -466,11 +466,6 @@  static void batadv_iv_ogm_emit(struct batadv_forw_packet *forw_packet)
 	struct net_device *soft_iface;
 	struct batadv_priv *bat_priv;
 	struct batadv_hard_iface *primary_if = NULL;
-	struct batadv_ogm_packet *batadv_ogm_packet;
-	uint8_t *packet_pos;
-
-	packet_pos = forw_packet->skb->data;
-	batadv_ogm_packet = (struct batadv_ogm_packet *)packet_pos;
 
 	if (!forw_packet->if_incoming) {
 		pr_err("Error - can't forward packet: incoming iface not specified\n");