diff mbox

batman-adv: use batadv_compare_eth when possible

Message ID 1388921809-4005-1-git-send-email-antonio@meshcoding.com
State Superseded, archived
Delegated to: Marek Lindner
Headers show

Commit Message

Antonio Quartulli Jan. 5, 2014, 11:36 a.m. UTC
When comparing Ethernet address it is better to use the more
generic batadv_compare_eth. The latter is also optimised for
architectures having a fast unaligned access.

Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
 network-coding.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Antonio Quartulli Jan. 6, 2014, 8:16 a.m. UTC | #1
On 05/01/14 12:36, Antonio Quartulli wrote:
> When comparing Ethernet address it is better to use the more
> generic batadv_compare_eth. The latter is also optimised for
> architectures having a fast unaligned access.
> 
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>

Martin,

I forgot to add you to the CC list :) Sorry!


Cheers,
Sven Eckelmann March 10, 2016, 6:39 p.m. UTC | #2
On Sunday 05 January 2014 12:36:49 Antonio Quartulli wrote:
> When comparing Ethernet address it is better to use the more
> generic batadv_compare_eth. The latter is also optimised for
> architectures having a fast unaligned access.
> 
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---

It looks like this patch doesn't apply anymore. Can you please resent it or
mark it correctly in patchwork [1].

But for the cleanup:

Acked-by: Sven Eckelmann <sven@narfation.org>

Thanks,
        Sven

[1] https://patchwork.open-mesh.org/patch/3769/
diff mbox

Patch

diff --git a/network-coding.c b/network-coding.c
index f1b604d..0049e7a 100644
--- a/network-coding.c
+++ b/network-coding.c
@@ -481,12 +481,10 @@  static int batadv_nc_hash_compare(const struct hlist_node *node,
 	nc_path2 = data2;
 
 	/* Return 1 if the two keys are identical */
-	if (memcmp(nc_path1->prev_hop, nc_path2->prev_hop,
-		   sizeof(nc_path1->prev_hop)) != 0)
+	if (!batadv_compare_eth(nc_path1->prev_hop, nc_path2->prev_hop))
 		return 0;
 
-	if (memcmp(nc_path1->next_hop, nc_path2->next_hop,
-		   sizeof(nc_path1->next_hop)) != 0)
+	if (!batadv_compare_eth(nc_path1->next_hop, nc_path2->next_hop))
 		return 0;
 
 	return 1;