diff mbox

[maint] batman-adv: fix TT-TVLV parsing on OGM reception

Message ID 1390821808-3855-1-git-send-email-antonio@meshcoding.com (mailing list archive)
State Accepted, archived
Commit db13d361ff6abf57090acfdeb0f5cedd8dd7f02e
Headers

Commit Message

Antonio Quartulli Jan. 27, 2014, 11:23 a.m. UTC 
  When accessing a TT-TVLV container in the OGM RX path
the variable pointing to the list of changes to apply is
altered by mistake.

This makes the TT component read data at the wrong position
in the OGM packet buffer.

Fix it by removing the bogus pointer alteration.

Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
 translation-table.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Marek Lindner Jan. 29, 2014, 4:44 a.m. UTC | #1 
On Monday 27 January 2014 12:23:28 Antonio Quartulli wrote:
> When accessing a TT-TVLV container in the OGM RX path
> the variable pointing to the list of changes to apply is
> altered by mistake.
> 
> This makes the TT component read data at the wrong position
> in the OGM packet buffer.
> 
> Fix it by removing the bogus pointer alteration.
> 
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---
>  translation-table.c | 1 -
>  1 file changed, 1 deletion(-)

Applied in revision db13d36.

Thanks,
Marek
diff mbox

Patch

diff --git a/translation-table.c b/translation-table.c
index 097ca01..05c2a9b 100644
--- a/translation-table.c
+++ b/translation-table.c
@@ -3208,7 +3208,6 @@  static void batadv_tt_update_orig(struct batadv_priv *bat_priv,
 
 		spin_lock_bh(&orig_node->tt_lock);
 
-		tt_change = (struct batadv_tvlv_tt_change *)tt_buff;
 		batadv_tt_update_changes(bat_priv, orig_node, tt_num_changes,
 					 ttvn, tt_change);