Message ID | 1392675155-26954-1-git-send-email-linus.luessing@web.de |
---|---|
State | Superseded, archived |
Commit | fb4756fe5f6e58ca2ab208ca634ae4c8dd6e9499 |
Headers | show |
On Monday 17 February 2014 23:12:35 Linus Lüssing wrote: > ether_addr_copy is supposed to be slightly more efficient for copying > mac addresses, so let's use it. This makes recent versions of checkpatch > happy, too. > > Reported-by: Antonio Quartulli <antonio@meshcoding.com> > Signed-off-by: Linus Lüssing <linus.luessing@web.de> > --- > multicast.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) We need an introduced by line, so Antonio later knows what patches to squash before sending them to David. Cheers, Marek
diff --git a/multicast.c b/multicast.c index 00bb30e..e69143b 100644 --- a/multicast.c +++ b/multicast.c @@ -45,7 +45,7 @@ static int batadv_mcast_mla_softif_get(struct net_device *dev, break; } - memcpy(&new->addr, &mc_list_entry->addr, ETH_ALEN); + ether_addr_copy(&new->addr, &mc_list_entry->addr); hlist_add_head(&new->list, mcast_list); ret++; }
ether_addr_copy is supposed to be slightly more efficient for copying mac addresses, so let's use it. This makes recent versions of checkpatch happy, too. Reported-by: Antonio Quartulli <antonio@meshcoding.com> Signed-off-by: Linus Lüssing <linus.luessing@web.de> --- multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)