From patchwork Tue Feb 18 08:14:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Linus_L=C3=BCssing?= X-Patchwork-Id: 3851 Return-Path: Received: from mout.web.de (mout.web.de [212.227.15.4]) by open-mesh.org (Postfix) with ESMTPS id 2007B6006D9 for ; Tue, 18 Feb 2014 09:13:27 +0100 (CET) Received: from localhost ([95.211.148.154]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0Mg7Dt-1WcXse0Of7-00NQnI for ; Tue, 18 Feb 2014 09:13:25 +0100 From: =?UTF-8?q?Linus=20L=C3=BCssing?= To: b.a.t.m.a.n@lists.open-mesh.org Date: Tue, 18 Feb 2014 09:14:05 +0100 Message-Id: <1392711245-29837-1-git-send-email-linus.luessing@web.de> X-Mailer: git-send-email 1.9.0.rc3 MIME-Version: 1.0 X-Provags-ID: V03:K0:hD3GF+wXRG4lJdzsDSr0yTw2bfIg70qI2eIp97YqPHEWgc9OU/q LP45WYiJby1kceAT3jxl6zY+y4Avm8XfnOPnOt73Tf+keIjF4DBdMdtDBJt6PIwVbvQvm8u CI/Z+jjZP0pY9q1mG+2tNap9H0Q2HvxYYX3wnUs2dsEXHYaPBfprSZM+Tu9N/uWTrf/5FNh XwbJtx3KZ7RuB/UepRgLA== Subject: [B.A.T.M.A.N.] [PATCHv2] batman-adv: use ether_addr_copy instead of memcpy in multicast code X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Feb 2014 08:13:27 -0000 ether_addr_copy is supposed to be slightly more efficient for copying mac addresses, so let's use it. This makes recent versions of checkpatch happy, too. Introduced by e368857f66620b8483166e8e6556d9c87f9b3e71 ("batman-adv: Multicast Listener Announcements via Translation Table") Reported-by: Antonio Quartulli Signed-off-by: Linus Lüssing --- multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/multicast.c b/multicast.c index 00bb30e..e69143b 100644 --- a/multicast.c +++ b/multicast.c @@ -45,7 +45,7 @@ static int batadv_mcast_mla_softif_get(struct net_device *dev, break; } - memcpy(&new->addr, &mc_list_entry->addr, ETH_ALEN); + ether_addr_copy(&new->addr, &mc_list_entry->addr); hlist_add_head(&new->list, mcast_list); ret++; }