[v2,10/26] batman-adv: iv_ogm_aggr_packet, bool return value

Message ID 1419594103-10928-11-git-send-email-mpa@pengutronix.de (mailing list archive)
State Accepted, archived
Headers

Commit Message

Markus Pargmann Dec. 26, 2014, 11:41 a.m. UTC
  This function returns bool values, so it should be defined to return
them instead of the whole int range.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 bat_iv_ogm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Marek Lindner Jan. 11, 2015, 12:48 p.m. UTC | #1
On Friday 26 December 2014 12:41:27 Markus Pargmann wrote:
> This function returns bool values, so it should be defined to return
> them instead of the whole int range.
> 
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  bat_iv_ogm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied in revision ec3b2d9.

Thanks,
Marek
  

Patch

diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c
index 92eeed406663..b267afab65bb 100644
--- a/bat_iv_ogm.c
+++ b/bat_iv_ogm.c
@@ -394,8 +394,8 @@  static uint8_t batadv_hop_penalty(uint8_t tq,
 }
 
 /* is there another aggregated packet here? */
-static int batadv_iv_ogm_aggr_packet(int buff_pos, int packet_len,
-				     __be16 tvlv_len)
+static bool batadv_iv_ogm_aggr_packet(int buff_pos, int packet_len,
+				      __be16 tvlv_len)
 {
 	int next_buff_pos = 0;