diff mbox

[v2,22/26] batman-adv: main, batadv_compare_eth return bool

Message ID 1419594103-10928-23-git-send-email-mpa@pengutronix.de (mailing list archive)
State Accepted, archived
Headers

Commit Message

Markus Pargmann Dec. 26, 2014, 11:41 a.m. UTC 
  Declare the returntype of batadv_compare_eth as bool.
The function called inside this helper function
(ether_addr_equal_unaligned) also uses bool as return value, so there is
no need to return int.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 main.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Lindner March 11, 2015, 9:48 a.m. UTC | #1 
On Friday, December 26, 2014 12:41:39 Markus Pargmann wrote:
> Declare the returntype of batadv_compare_eth as bool.
> The function called inside this helper function
> (ether_addr_equal_unaligned) also uses bool as return value, so there is
> no need to return int.
> 
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  main.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied in revision 16af734.

Thanks,
Marek
diff mbox

Patch

diff --git a/main.h b/main.h
index 6cd339090658..2e70d4dc748d 100644
--- a/main.h
+++ b/main.h
@@ -218,7 +218,7 @@  __be32 batadv_skb_crc32(struct sk_buff *skb, u8 *payload_ptr);
  *
  * note: can't use ether_addr_equal() as it requires aligned memory
  */
-static inline int batadv_compare_eth(const void *data1, const void *data2)
+static inline bool batadv_compare_eth(const void *data1, const void *data2)
 {
 	return ether_addr_equal_unaligned(data1, data2);
 }