diff mbox

batman-adv: remove redundant hard_iface assignment

Message ID 1437856667-27139-1-git-send-email-mareklindner@neomailbox.ch (mailing list archive)
State Accepted, archived
Commit f645ed95afc2fbf340a6e25352dadbd8e115a753
Headers

Commit Message

Marek Lindner July 25, 2015, 8:37 p.m. UTC 
  The batadv_neigh_node_new() function already sets the hard_iface pointer.

Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
---
 net/batman-adv/bat_iv_ogm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Simon Wunderlich Aug. 3, 2015, 6:01 p.m. UTC | #1 
On Sunday 26 July 2015 04:37:47 Marek Lindner wrote:
> The batadv_neigh_node_new() function already sets the hard_iface pointer.
> 
> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>

Acked-by: Simon Wunderlich <sw@simonwunderlich.de>

Cheers,
   Simon
Marek Lindner Aug. 3, 2015, 7:55 p.m. UTC | #2 
On Monday, August 03, 2015 20:01:03 Simon Wunderlich wrote:
> On Sunday 26 July 2015 04:37:47 Marek Lindner wrote:
> > The batadv_neigh_node_new() function already sets the hard_iface pointer.
> >
> > 
> >
> > Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
> 
> Acked-by: Simon Wunderlich <sw@simonwunderlich.de>

Applied in revision f645ed9.

Regards,
Marek
diff mbox

Patch

diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c
index b9b8b33..b18184e 100644
--- a/net/batman-adv/bat_iv_ogm.c
+++ b/net/batman-adv/bat_iv_ogm.c
@@ -304,7 +304,6 @@  batadv_iv_ogm_neigh_new(struct batadv_hard_iface *hard_iface,
 		goto out;
 
 	neigh_node->orig_node = orig_neigh;
-	neigh_node->if_incoming = hard_iface;
 
 	spin_lock_bh(&orig_node->neigh_list_lock);
 	tmp_neigh_node = batadv_neigh_node_get(orig_node, hard_iface,