diff mbox

[maint,3/4] batman-adv: unify flags access style in tt global add

Message ID 1440170118-10876-4-git-send-email-sw@simonwunderlich.de (mailing list archive)
State Superseded, archived
Commit d7380251fc66cc3902c4b00643f4715ff4c71e2e
Headers

Commit Message

Simon Wunderlich Aug. 21, 2015, 3:15 p.m. UTC 
  This should slightly improve readability

Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
 net/batman-adv/translation-table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Antonio Quartulli Aug. 25, 2015, 9:51 a.m. UTC | #1 
On 21/08/15 17:15, Simon Wunderlich wrote:
> This should slightly improve readability
> 

Patch looks good, but it is definitely *not* for maint.

Cheers,
Simon Wunderlich Aug. 25, 2015, 3:28 p.m. UTC | #2 
On Tuesday 25 August 2015 11:51:24 Antonio Quartulli wrote:
> On 21/08/15 17:15, Simon Wunderlich wrote:
> > This should slightly improve readability
> 
> Patch looks good, but it is definitely *not* for maint.
> 
> Cheers,

Shall I keep it in the patchset, and our friendly maintainer can merge it on 
master instead? Or do you prefer to send it separately?

Thanks,
    Simo
Antonio Quartulli Aug. 25, 2015, 4:14 p.m. UTC | #3 
On 25/08/15 17:28, Simon Wunderlich wrote:
> On Tuesday 25 August 2015 11:51:24 Antonio Quartulli wrote:
>> On 21/08/15 17:15, Simon Wunderlich wrote:
>>> This should slightly improve readability
>>
>> Patch looks good, but it is definitely *not* for maint.
>>
>> Cheers,
> 
> Shall I keep it in the patchset, and our friendly maintainer can merge it on 
> master instead? Or do you prefer to send it separately?

Up to the friendly maintainer. but if you ask me it is better to send
this patch separately.

Cheers,
diff mbox

Patch

diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index f629c21..dced2da 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -1430,7 +1430,7 @@  static bool batadv_tt_global_add(struct batadv_priv *bat_priv,
 		 * TT_CLIENT_WIFI, therefore they have to be copied in the
 		 * client entry
 		 */
-		tt_global_entry->common.flags |= flags;
+		common->flags |= flags;
 
 		/* If there is the BATADV_TT_CLIENT_ROAM flag set, there is only
 		 * one originator left in the list and we previously received a