pull request [net]: batman-adv 20160117
Message ID | 1453008281-15396-1-git-send-email-a@unstable.cc (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers |
Return-Path: <a@unstable.cc> Received-SPF: Permerror (SPF Permanent Error: Two or more type TXT spf records found.) identity=mailfrom; client-ip=5.148.176.57; helo=s1.neomailbox.net; envelope-from=a@unstable.cc; receiver=b.a.t.m.a.n@lists.open-mesh.org Authentication-Results: open-mesh.org; dmarc=none header.from=unstable.cc Received: from s1.neomailbox.net (s1.neomailbox.net [5.148.176.57]) by open-mesh.org (Postfix) with ESMTPS id 3722C81AE3 for <b.a.t.m.a.n@lists.open-mesh.org>; Sun, 17 Jan 2016 06:26:41 +0100 (CET) From: Antonio Quartulli <a@unstable.cc> To: davem@davemloft.net Date: Sun, 17 Jan 2016 13:24:33 +0800 Message-Id: <1453008281-15396-1-git-send-email-a@unstable.cc> Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org Subject: [B.A.T.M.A.N.] pull request [net]: batman-adv 20160117 X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n.lists.open-mesh.org> List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe> List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/> List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org> List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help> List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>, <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe> X-List-Received-Date: Sun, 17 Jan 2016 05:26:41 -0000 |
Pull-request
git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davemMessage
Antonio Quartulli
Jan. 17, 2016, 5:24 a.m. UTC
Hello David, here you have a bunch of patches intended for net. This patchset is provided by Sven Eckelmann and it is basically fixing 2 major issues that exist in several parts of the code - that is why we have 8 patches. The first bugfix (patch 1 and 2) is preventing call_rcu from being invoked recursively. This would deceive any user waiting on rcu_barrier() because the latter won't be able to wait for the nested invocation thus triggering any sort of undefined behaviours. The second bugfix (patches from 3 to 8) prevents the code from freeing rcu protected objects without waiting for the proper grace period. This issue can potentially lead to wrong memory access and thus kernel crashes. Unfortunately this bogus code pattern was copy/pasted all around the place when developing new features, therefore Sven diligently created several patches to address each component independently. Given that such bugs were introduced quite some time ago, all the patches except patch 5 should be considered for submission to stable. Please pull or let me know of any issue! Thanks a lot, Antonio The following changes since commit 6c3f5aef1159a278b54642ebc0bbb5cdab7630cf: bna: fix Rx data corruption with VLAN stripping enabled and MTU > 4096 (2016-01-15 21:49:25 -0500) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davem for you to fetch changes up to 42eff6a617e23b691f8e4467f4687ed7245a92db: batman-adv: Drop immediate orig_node free function (2016-01-16 22:50:00 +0800) ---------------------------------------------------------------- Included changes: - avoid recursive invocations of call_rcu() which would fool users waiting on rcu_barrier() - prevent immediate kfree of objects used in rcu protected contexts ---------------------------------------------------------------- Sven Eckelmann (8): batman-adv: Avoid recursive call_rcu for batadv_bla_claim batman-adv: Avoid recursive call_rcu for batadv_nc_node batman-adv: Drop immediate batadv_orig_ifinfo free function batman-adv: Drop immediate batadv_neigh_node free function batman-adv: Drop immediate batadv_hardif_neigh_node free function batman-adv: Drop immediate neigh_ifinfo free function batman-adv: Drop immediate batadv_hard_iface free function batman-adv: Drop immediate orig_node free function net/batman-adv/bridge_loop_avoidance.c | 10 +- net/batman-adv/hard-interface.h | 12 -- net/batman-adv/network-coding.c | 19 ++-- net/batman-adv/originator.c | 196 ++++++++++++--------------------- net/batman-adv/originator.h | 1 - net/batman-adv/translation-table.c | 28 +++-- 6 files changed, 94 insertions(+), 172 deletions(-)
Comments
From: Antonio Quartulli <a@unstable.cc> Date: Sun, 17 Jan 2016 13:24:33 +0800 > here you have a bunch of patches intended for net. Pulled, but you really need to sort something out. You give really nice detailed, high level, descriptions of your changes here in this pull request. It is awesome. But then you include other text in the merge commit I end up getting when I pull. I don't want that _UNLESS_ it's exactly what you're saying here in this email and therefore is what I would have put there anyways. When I did this time is just concatenate them together and therefore including both things. But I don't want to have to even think about this in the future. Just let me include what you say in this email or put exactly this text into that merge commit. Thanks.
On 17/01/16 14:04, David Miller wrote: > Just let me include what you say in this email or put exactly this > text into that merge commit. > Thanks for explaining this, David. Next time I'll put in the git tag the same text as the email (I'll just drop references to patch numbers because those are not really useful in the git log). Cheers,
From: Antonio Quartulli <a@unstable.cc> Date: Sun, 17 Jan 2016 14:12:32 +0800 > On 17/01/16 14:04, David Miller wrote: >> Just let me include what you say in this email or put exactly this >> text into that merge commit. >> > > Thanks for explaining this, David. > > Next time I'll put in the git tag the same text as the email (I'll just > drop references to patch numbers because those are not really useful in > the git log). Thanks!