diff mbox

[2/2] batman-adv: fix debuginfo macro style issue

Message ID 1457701271-24248-2-git-send-email-sven@narfation.org (mailing list archive)
State Accepted, archived
Commit 2d34b55ac0cc42be3a60d692f5d70850b7b36294
Delegated to: Marek Lindner
Headers

Commit Message

Sven Eckelmann March 11, 2016, 1:01 p.m. UTC 
  From: Simon Wunderlich <simon.wunderlich@open-mesh.com>

Structure initialization within the macros should follow the general
coding style used in the kernel: put the initialization of the first
variable and the closing brace on a separate line.

Reported-by: Antonio Quartulli <a@unstable.cc>
Signed-off-by: Simon Wunderlich <simon.wunderlich@open-mesh.com>
[sven@narfation.org: fix conflicts with current version]
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
Patch was resurrected from https://patchwork.open-mesh.org/patch/3769/

I've requested an rebased version at
https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-March/014638.html
but done it myself because it was rather trivial.
---
 net/batman-adv/debugfs.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

Comments

Marek Lindner March 28, 2016, 3:14 p.m. UTC | #1 
On Friday, March 11, 2016 14:01:11 Sven Eckelmann wrote:
> From: Simon Wunderlich <simon.wunderlich@open-mesh.com>
> 
> Structure initialization within the macros should follow the general
> coding style used in the kernel: put the initialization of the first
> variable and the closing brace on a separate line.
> 
> Reported-by: Antonio Quartulli <a@unstable.cc>
> Signed-off-by: Simon Wunderlich <simon.wunderlich@open-mesh.com>
> [sven@narfation.org: fix conflicts with current version]
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> Patch was resurrected from https://patchwork.open-mesh.org/patch/3769/
> 
> I've requested an rebased version at
> https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-March/014638.html
> but done it myself because it was rather trivial.
> ---
>  net/batman-adv/debugfs.c | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)

Applied in revision 2d34b55.

Thanks,
Marek
diff mbox

Patch

diff --git a/net/batman-adv/debugfs.c b/net/batman-adv/debugfs.c
index 3dc5208..9529004 100644
--- a/net/batman-adv/debugfs.c
+++ b/net/batman-adv/debugfs.c
@@ -365,14 +365,17 @@  static int batadv_nc_nodes_open(struct inode *inode, struct file *file)
 
 #define BATADV_DEBUGINFO(_name, _mode, _open)		\
 struct batadv_debuginfo batadv_debuginfo_##_name = {	\
-	.attr = { .name = __stringify(_name),		\
-		  .mode = _mode, },			\
-	.fops = { .owner = THIS_MODULE,			\
-		  .open = _open,			\
-		  .read	= seq_read,			\
-		  .llseek = seq_lseek,			\
-		  .release = single_release,		\
-		}					\
+	.attr = {					\
+		.name = __stringify(_name),		\
+		.mode = _mode,				\
+	},						\
+	.fops = {					\
+		.owner = THIS_MODULE,			\
+		.open = _open,				\
+		.read	= seq_read,			\
+		.llseek = seq_lseek,			\
+		.release = single_release,		\
+	},						\
 }
 
 /* the following attributes are general and therefore they will be directly