diff mbox

[maint,v2] batman-adv: make sure ELP/OGM orig MAC is updated on address change

Message ID 1462137808-719-1-git-send-email-a@unstable.cc (mailing list archive)
State Superseded, archived
Delegated to: Marek Lindner
Headers

Commit Message

Antonio Quartulli May 1, 2016, 9:23 p.m. UTC 
  When the MAC address of the primary interface is changed,
update the originator address in the ELP and OGM skb buffers as
well in order to reflect the change.

Fixes: a4b88af77e28 ("batman-adv: ELP - adding basic infrastructure")
Reported-by: Marek Lindner <marek@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 net/batman-adv/bat_v.c | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

Comments

Marek Lindner May 2, 2016, 10:05 a.m. UTC | #1 
On Monday, May 02, 2016 05:23:28 Antonio Quartulli wrote:
> +static void batadv_v_iface_update_mac(struct batadv_hard_iface *hard_iface)
> +{
> +       struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);
> +       struct batadv_hard_iface *primary_if;
> +
> +       primary_if = batadv_primary_if_get_selected(bat_priv);
> +       if (primary_if != hard_iface)
> +               goto out;
> +
> +       batadv_v_primary_iface_set(hard_iface);
> +out:
> +       if (primary_if)
> +               batadv_hardif_put(primary_if);
> +}

Please provide kernel doc.

Thanks,
Marek
diff mbox

Patch

diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c
index 4026f19..4ed3d5e 100644
--- a/net/batman-adv/bat_v.c
+++ b/net/batman-adv/bat_v.c
@@ -72,16 +72,27 @@  static void batadv_v_iface_disable(struct batadv_hard_iface *hard_iface)
 	batadv_v_elp_iface_disable(hard_iface);
 }
 
-static void batadv_v_iface_update_mac(struct batadv_hard_iface *hard_iface)
-{
-}
-
 static void batadv_v_primary_iface_set(struct batadv_hard_iface *hard_iface)
 {
 	batadv_v_elp_primary_iface_set(hard_iface);
 	batadv_v_ogm_primary_iface_set(hard_iface);
 }
 
+static void batadv_v_iface_update_mac(struct batadv_hard_iface *hard_iface)
+{
+	struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);
+	struct batadv_hard_iface *primary_if;
+
+	primary_if = batadv_primary_if_get_selected(bat_priv);
+	if (primary_if != hard_iface)
+		goto out;
+
+	batadv_v_primary_iface_set(hard_iface);
+out:
+	if (primary_if)
+		batadv_hardif_put(primary_if);
+}
+
 static void
 batadv_v_hardif_neigh_init(struct batadv_hardif_neigh_node *hardif_neigh)
 {