From patchwork Sun Jul 10 10:59:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Eckelmann X-Patchwork-Id: 16498 Return-Path: X-Original-To: patchwork@open-mesh.org Delivered-To: patchwork@open-mesh.org Received: from open-mesh.org (localhost [IPv6:::1]) by open-mesh.org (Postfix) with ESMTP id 6B2838247F; Sun, 10 Jul 2016 12:59:43 +0200 (CEST) Authentication-Results: open-mesh.org; dmarc=none header.from=narfation.org Authentication-Results: open-mesh.org; dkim=fail reason="verification failed; unprotected key" header.d=narfation.org header.i=@narfation.org header.b=Fyj1Ljx6; dkim-adsp=fail (unprotected policy); dkim-atps=neutral Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=79.140.41.39; helo=v3-1039.vlinux.de; envelope-from=sven@narfation.org; receiver=b.a.t.m.a.n@lists.open-mesh.org Authentication-Results: open-mesh.org; dmarc=pass header.from=narfation.org Received: from v3-1039.vlinux.de (narfation.org [79.140.41.39]) by open-mesh.org (Postfix) with ESMTPS id C47D482498 for ; Sun, 10 Jul 2016 12:59:40 +0200 (CEST) Received: from sven-desktop.home.narfation.org (p200300C593C5C6F96A1729FFFEE0E6EC.dip0.t-ipconnect.de [IPv6:2003:c5:93c5:c6f9:6a17:29ff:fee0:e6ec]) by v3-1039.vlinux.de (Postfix) with ESMTPSA id 794341C8001; Sun, 10 Jul 2016 12:59:39 +0200 (CEST) Authentication-Results: v3-1039.vlinux.de; dmarc=none header.from=narfation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=narfation.org; s=20121; t=1468148379; bh=H0wvTm+CcydhmysomrD/jMnEkHiaws/+e1G82Nt6Vlw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fyj1Ljx6LwSVqlXOtVDyzM/NBEVJqeHxA0YA14fK7ji6Sj0aopqzDiIC3XrRWH/2j fcAsPQBHwxUe8/zWmhyPteO31hNWetDPor+oiptJqOUxSBiC21H/U+coPq9LxDJCdn 9Jvl7HNpQqfDZV/eZJz5LytXG3SSXe0W614yP5yY= From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.org Date: Sun, 10 Jul 2016 12:59:29 +0200 Message-Id: <1468148369-17048-2-git-send-email-sven@narfation.org> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1468148369-17048-1-git-send-email-sven@narfation.org> References: <1468148369-17048-1-git-send-email-sven@narfation.org> Subject: [B.A.T.M.A.N.] [RFC 2/2] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default X-BeenThere: b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Errors-To: b.a.t.m.a.n-bounces@lists.open-mesh.org Sender: "B.A.T.M.A.N" All tools which were known to the batman-adv development team are supporting the batman-adv netlink interface since a while. Thus disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause problems on most systems. It is still possible to enable it in case it is still required in a specific setup Signed-off-by: Sven Eckelmann --- Of course, this patch is for the future - not now. --- Makefile | 2 +- README.external | 2 +- gen-compat-autoconf.sh | 2 +- net/batman-adv/Kconfig | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index d42bb56..84bacdc 100644 --- a/Makefile +++ b/Makefile @@ -18,7 +18,7 @@ # read README.external for more information about the configuration # batman-adv DebugFS entries: -export CONFIG_BATMAN_ADV_DEBUGFS=y +export CONFIG_BATMAN_ADV_DEBUGFS=n # B.A.T.M.A.N. debugging: export CONFIG_BATMAN_ADV_DEBUG=n # B.A.T.M.A.N. bridge loop avoidance: diff --git a/README.external b/README.external index ec04364..d8470f2 100644 --- a/README.external +++ b/README.external @@ -35,7 +35,7 @@ option can be set to to y (enabled), n (disabled) or m (build as module). Available options and their possible values are (default marked with an "*") - * CONFIG_BATMAN_ADV_DEBUGFS=[y*|n] (B.A.T.M.A.N. debugfs entries) + * CONFIG_BATMAN_ADV_DEBUGFS=[y|n*] (B.A.T.M.A.N. debugfs entries) * CONFIG_BATMAN_ADV_DEBUG=[y|n*] (B.A.T.M.A.N. debugging) * CONFIG_BATMAN_ADV_BLA=[y*|n] (B.A.T.M.A.N. bridge loop avoidance) * CONFIG_BATMAN_ADV_DAT=[y*|n] (B.A.T.M.A.N. Distributed ARP Table) diff --git a/gen-compat-autoconf.sh b/gen-compat-autoconf.sh index cf36e55..d27f3fb 100755 --- a/gen-compat-autoconf.sh +++ b/gen-compat-autoconf.sh @@ -36,7 +36,7 @@ gen_config() { } # write config variables -gen_config 'CONFIG_BATMAN_ADV_DEBUGFS' ${CONFIG_BATMAN_ADV_DEBUGFS:="y"} >> "${TMP}" +gen_config 'CONFIG_BATMAN_ADV_DEBUGFS' ${CONFIG_BATMAN_ADV_DEBUGFS:="n"} >> "${TMP}" gen_config 'CONFIG_BATMAN_ADV_DEBUG' ${CONFIG_BATMAN_ADV_DEBUG:="n"} >> "${TMP}" gen_config 'CONFIG_BATMAN_ADV_BLA' ${CONFIG_BATMAN_ADV_BLA:="y"} >> "${TMP}" gen_config 'CONFIG_BATMAN_ADV_DAT' ${CONFIG_BATMAN_ADV_DAT:="y"} >> "${TMP}" diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig index d9b71a1..1e220a0 100644 --- a/net/batman-adv/Kconfig +++ b/net/batman-adv/Kconfig @@ -77,13 +77,13 @@ config BATMAN_ADV_DEBUGFS bool "batman-adv debugfs entries" depends on BATMAN_ADV depends on DEBUG_FS - default y + default n help Enable this to export routing related debug tables via debugfs. The information for each soft-interface and used hard-interface can be found under batman_adv/ - If unsure, say Y. + If unsure, say N. config BATMAN_ADV_DEBUG bool "B.A.T.M.A.N. debugging"