batman-adv: Use bitwise instead of arithmetic operator for flags
Commit Message
This silences the following coccinelle warning:
"WARNING: sum of probable bitmasks, consider |"
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
net/batman-adv/multicast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Montag, 11. Juli 2016 11:16:36 CEST Linus Lüssing wrote:
> This silences the following coccinelle warning:
>
> "WARNING: sum of probable bitmasks, consider |"
>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
> net/batman-adv/multicast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Sven Eckelmann <sven@narfation.org>
Kind regards,
Sven
On Monday, July 11, 2016 11:38:19 Sven Eckelmann wrote:
> On Montag, 11. Juli 2016 11:16:36 CEST Linus Lüssing wrote:
> > This silences the following coccinelle warning:
> >
> > "WARNING: sum of probable bitmasks, consider |"
> >
> > Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> > ---
> >
> > net/batman-adv/multicast.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Sven Eckelmann <sven@narfation.org>
Applied in revision f0935ab.
Thanks,
Marek
@@ -528,7 +528,7 @@ update:
}
return !(mcast_data.flags &
- (BATADV_MCAST_WANT_ALL_IPV4 + BATADV_MCAST_WANT_ALL_IPV6));
+ (BATADV_MCAST_WANT_ALL_IPV4 | BATADV_MCAST_WANT_ALL_IPV6));
}
/**