diff mbox

[v2,02/18] batman-adv: Place kref_get for orig_ifinfo near use

Message ID 1468597173-25378-2-git-send-email-sven@narfation.org (mailing list archive)
State Accepted, archived
Commit 180df6d42c042f60d216e7db9705a7423f632c30
Delegated to: Marek Lindner
Headers

Commit Message

Sven Eckelmann July 15, 2016, 3:39 p.m. UTC 
  It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems causedy incorrect reference counting.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
v2:
 - split patch based on type

 net/batman-adv/originator.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Marek Lindner July 19, 2016, 8:08 a.m. UTC | #1 
On Friday, July 15, 2016 17:39:17 Sven Eckelmann wrote:
> It is hard to understand why the refcnt is increased when it isn't done
> near the actual place the new reference is used. So using kref_get right
> before the place which requires the reference and in the same function
> helps to avoid accidental problems causedy incorrect reference counting.
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v2:
>  - split patch based on type
> 
>  net/batman-adv/originator.c | 1 +
>  1 file changed, 1 insertion(+)

Applied in revision 180df6d.

Thanks,
Marek
diff mbox

Patch

diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index d778eb1..1db577d 100644
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -380,6 +380,7 @@  batadv_orig_ifinfo_new(struct batadv_orig_node *orig_node,
 	orig_ifinfo->if_outgoing = if_outgoing;
 	INIT_HLIST_NODE(&orig_ifinfo->list);
 	kref_init(&orig_ifinfo->refcount);
+
 	kref_get(&orig_ifinfo->refcount);
 	hlist_add_head_rcu(&orig_ifinfo->list,
 			   &orig_node->ifinfo_list);