diff mbox

[v2,05/18] batman-adv: Place kref_get for neigh_node near use

Message ID 1468597173-25378-5-git-send-email-sven@narfation.org (mailing list archive)
State Accepted, archived
Commit 9904e1bf1369c8f35000c67b4ce3f0127b01081b
Delegated to: Marek Lindner
Headers

Commit Message

Sven Eckelmann July 15, 2016, 3:39 p.m. UTC 
  It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems causedy incorrect reference counting.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
v2:
 - split patch based on type

 net/batman-adv/originator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Lindner July 19, 2016, 8:10 a.m. UTC | #1 
On Friday, July 15, 2016 17:39:20 Sven Eckelmann wrote:
> It is hard to understand why the refcnt is increased when it isn't done
> near the actual place the new reference is used. So using kref_get right
> before the place which requires the reference and in the same function
> helps to avoid accidental problems causedy incorrect reference counting.
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v2:
>  - split patch based on type
> 
>  net/batman-adv/originator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied in revision 9904e1b.

Thanks,
Marek
diff mbox

Patch

diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index 1de583d..3bf3065 100644
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -648,8 +648,8 @@  batadv_neigh_node_create(struct batadv_orig_node *orig_node,
 
 	/* extra reference for return */
 	kref_init(&neigh_node->refcount);
-	kref_get(&neigh_node->refcount);
 
+	kref_get(&neigh_node->refcount);
 	hlist_add_head_rcu(&neigh_node->list, &orig_node->neigh_list);
 
 	batadv_dbg(BATADV_DBG_BATMAN, orig_node->bat_priv,